Skip to content

Fix upstream failure branch in task lifecycle diagram - #71101

Closed
YAshhh29 wants to merge 1 commit into
apache:mainfrom
YAshhh29:fix-task-lifecycle-diagram
Closed

YAshhh29 wants to merge 1 commit into
apache:mainfrom
YAshhh29:fix-task-lifecycle-diagram

Conversation

@YAshhh29

@YAshhh29 YAshhh29 commented Aug 4, 2026 •

Copy link
Copy Markdown
Contributor

While I was tracing the task lifecycle, I noticed that the branches after
"Required upstream task(s) failed?" are reversed in the diagram.

A YES answer currently continues through the normal scheduling checks,
while NO leads to upstream_failed. It should be the other way around:
when a required upstream task has failed, the current task moves to
upstream_failed; otherwise, the Scheduler continues evaluating it.

This PR swaps those two labels and regenerates the PNG and its source
checksum.

Validation:

  • prek run generate-airflow-diagrams --files airflow-core/docs/img/diagram_task_lifecycle.py
  • prek run ruff --files airflow-core/docs/img/diagram_task_lifecycle.py
  • prek run --from-ref upstream/main --stage manual

Was generative AI tooling used to co-author this PR?
  • Yes - GitHub Copilot

The PNG was regenerated deterministically from the diagram source using Airflow's Graphviz hook.

A positive upstream-failure decision currently follows the normal scheduling path, while a negative decision marks the task upstream_failed. This reverses the documented task lifecycle semantics.
@YAshhh29
YAshhh29 force-pushed the fix-task-lifecycle-diagram branch from 1983bf8 to d836903 Compare August 6, 2026 07:49
@potiuk potiuk added the ready for maintainer review Set by triage when all criteria pass, or by the fork CI reconciler when fork CI is green. label Aug 13, 2026
@uros-b

uros-b commented Aug 20, 2026

Copy link
Copy Markdown
Member

Thank you @YAshhh29!

@potiuk

potiuk commented Sep 25, 2026

Copy link
Copy Markdown
Member

Hello @YAshhh29 - thank you for your contributions to Apache Airflow!

The Airflow community has introduced a limit of 5 open pull requests at a time for contributors without write access to the repository. You currently have 6 open pull requests, so - as a one-time step of introducing the limit - we closed the ones where maintainers have not engaged yet:

These pull requests stay open because maintainers are already engaged in them - they count towards your limit:

This is not a judgement of you or of your changes. We never told contributors before that opening many pull requests at once was a problem, so there is nothing to feel bad about - and nothing is lost: your branches, commits and the review history stay where they are.

What we ask you to do is to make your first prioritization decision: choose which of the pull requests above matter most to you, and reopen them (up to 5 open at a time, including the ones still open) with the "Reopen pull request" button or gh pr reopen <PR_NUMBER> --repo apache/airflow. Reopen the ones you are ready to follow through - keep them rebased, respond to review comments and fix failing checks.

While your pull requests are waiting for review, the most valuable thing you can do is help in other ways - reviewing other contributors' pull requests, helping with issues, and taking part in the discussions on the devlist and Slack.

Why we introduced the limit, what it means for you and how to reopen or restore a pull request is explained in https://github.com/apache/airflow/blob/main/contributing-docs/32_open_pull_request_limit.rst.


Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

closed because of open PR limit Closed as a one-time step of introducing the open pull request limit kind:documentation ready for maintainer review Set by triage when all criteria pass, or by the fork CI reconciler when fork CI is green.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants