Repository navigation
Conversation
Contributor
Author
|
Reopening this now that I'm under the open-PR limit. Rebased onto main and regenerated the checksum after the script metadata change in #74152. It's a two-line fix to the YES/NO labels on the upstream-failure branch of the diagram, so it should be quick to review whenever someone has a moment. |
YAshhh29
force-pushed
the
task-lifecycle-diagram-upstream-failed
branch
from
October 10, 2026 14:24
439e3a0 to
03ad257
Compare
This was referenced Oct 22, 2026
A positive upstream-failure decision currently follows the normal scheduling path, while a negative decision marks the task upstream_failed. This reverses the documented task lifecycle semantics.
YAshhh29
force-pushed
the
task-lifecycle-diagram-upstream-failed
branch
from
October 24, 2026 12:50
03ad257 to
1079258
Compare
Contributor
Author
|
Checked against a real Dag run: the task whose upstream failed ends in The workflows for the latest push are waiting for approval, if a maintainer could approve them. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Replaces #71101, which was closed under the open-PR limit and can't be reopened from my side. Same one-commit change, rebased onto main.
In the task lifecycle diagram, the two branches after "Required upstream task(s) failed?" are reversed.
YEScurrently continues through the normal scheduling checks andNOleads toupstream_failed. It should be the other way around: when a required upstream task has failed the task moves toupstream_failed, otherwise the scheduler keeps evaluating it.This swaps the two labels and updates the PNG and the source checksum. The checksum was recomputed after the rebase, since #74152 changed the script's metadata.
Before / after
The full diagram is very wide, so the change is hard to spot in the file diff. This is the part that changes:
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code following the guidelines