Repository navigation
Register TypeScript, Java and Go grammars for the Dag Code tab - #74231
Merged
pierrejeambrun merged 2 commits intoOct 5, 2026
Merged
pierrejeambrun merged 2 commits into
pierrejeambrun merged 2 commits into
Conversation
The Code tab already asks Monaco for whichever language the Dag source reports (Python, TypeScript, Java, Go), but the editor's minimal entry point only ever registered Python's tokenizer. A Dag authored in one of the other three languages fell back to Monaco's unhighlighted default rendering instead of real syntax coloring.
pierrejeambrun
marked this pull request as ready for review
October 5, 2026 12:29
pierrejeambrun
requested review from
bbovenzi,
choo121600,
guan404ming,
ryanahamilton,
shubhamraj-git and
vatsrahul1001
as code owners
October 5, 2026 12:29
Two near-identical registration blocks, one for Python and one for the rest, made it read as if Python were the odd one out needing no patch. It is the only one that does.
jason810496
approved these changes
Oct 5, 2026
jason810496
left a comment
jason810496
left a comment
Member
There was a problem hiding this comment.
Nice to see the vivid TS SDK Dag code on the UI! Thanks.
guan404ming
approved these changes
Oct 5, 2026
guan404ming
left a comment
guan404ming
left a comment
Member
There was a problem hiding this comment.
LGTM!
Non-blocking: I think adding a small vitest importing the typescript, java and go grammar modules could help catch export-shape drift in CI.
Member
Author
Let me follow up with such a test |
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Code tab already asks Monaco for whichever language the Dag's source reports (
DAGSourceResponse.language, already set to"python","typescript"or"java"by the respective Dag importers). But Monaco's minimal entry point only ever registered Python's tokenizer, so a Dag authored in TypeScript or Java rendered as flat, unhighlighted text instead of real syntax coloring. Go is registered too, ahead of a Go Dag importer.Before
After
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 4.7) following the guidelines