Repository navigation
Guard the Dag Code tab's Monaco grammar exports against drift - #74246
Merged
pierrejeambrun merged 2 commits intoOct 6, 2026
Merged
Conversation
The register-time shape guard in configureMonaco only runs in the browser when the Code tab mounts, so a Monaco upgrade that moved a grammar module or dropped its conf/language export would pass CI and only surface as silently-unhighlighted TypeScript, Java or Go source in production. A unit import of each module turns that drift into a CI failure instead.
pierrejeambrun
force-pushed
the
test-monaco-grammar-exports
branch
from
October 5, 2026 14:18
82c12e6 to
d408707
Compare
pierrejeambrun
marked this pull request as ready for review
October 5, 2026 22:40
pierrejeambrun
requested review from
bbovenzi,
choo121600,
guan404ming,
ryanahamilton,
shubhamraj-git and
vatsrahul1001
as code owners
October 5, 2026 22:40
jason810496
approved these changes
Oct 6, 2026
jason810496
left a comment
jason810496
left a comment
Member
There was a problem hiding this comment.
Thanks for the follow-up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #74231, which registers the TypeScript, Java and Go Monaco grammars for the Dag Code tab. That PR guards each grammar module's
conf/languageexport shape, but the guard only runs in the browser when the Code tab mounts — a Monaco upgrade that moved a grammar module or dropped an export would pass CI and only surface as silently-unhighlighted source in production.This adds a unit import of the three grammar modules so that drift becomes a CI failure instead: a moved module breaks resolution, a dropped export fails the assertion. Python is already exercised by the tokenized suite in
pythonFStrings.test.ts.Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Claude Opus 4.8) following the guidelines