Repository navigation
Fix Dag version diff max-changes border, limit wording and duplicate count - #74818
Merged
Merged
Conversation
jedcunningham
requested review from
Lee-W,
ashb,
bbovenzi,
bugraoz93,
choo121600,
guan404ming,
henry3260,
jason810496,
jscheffl,
mobuchowski,
pierrejeambrun,
potiuk,
ryanahamilton,
shubhamraj-git,
vatsrahul1001 and
vincbeck
as code owners
October 15, 2026 22:26
An empty Max changes field parsed to NaN, which the number input treats as out of range, so its normal unset state drew an error border. Pass `invalid` explicitly so only a real out-of-range value is flagged. When the comparison hits the limit, say "At least N changes" and "Showing only the first N changes" with a pointer to raise the limit, instead of the lower-bound wording. Render the warning title as an Alert.Title child: the raw Alert.Root only set it as an HTML title attribute. Drop the old truncation strings from translated locales. Hide the table's "N Records" heading: the summary already counts the changes, and the record count could disagree with it, since a redacted record stands for every change sharing its path.
jedcunningham
force-pushed
the
dag-version-diff-limit-ui
branch
from
October 16, 2026 15:55
e8839af to
d7973f5
Compare
bbovenzi
approved these changes
Oct 16, 2026
Contributor
Backport successfully created: v3-4-testNote: As of Merging PRs targeted for Airflow 3.X In matter of doubt please ask in #release-management Slack channel.
|
aws-airflow-bot
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Oct 16, 2026
…d duplicate count (apache#74818) An empty Max changes field parsed to NaN, which the number input treats as out of range, so its normal unset state drew an error border. Pass `invalid` explicitly so only a real out-of-range value is flagged. When the comparison hits the limit, say "At least N changes" and "Showing only the first N changes" with a pointer to raise the limit, instead of the lower-bound wording. Render the warning title as an Alert.Title child: the raw Alert.Root only set it as an HTML title attribute. Drop the old truncation strings from translated locales. Hide the table's "N Records" heading: the summary already counts the changes, and the record count could disagree with it, since a redacted record stands for every change sharing its path. (cherry picked from commit 23f4aee) Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
SameerMesiah97
pushed a commit
to SameerMesiah97/airflow-oss-sm97
that referenced
this pull request
Oct 27, 2026
…count (apache#74818) An empty Max changes field parsed to NaN, which the number input treats as out of range, so its normal unset state drew an error border. Pass `invalid` explicitly so only a real out-of-range value is flagged. When the comparison hits the limit, say "At least N changes" and "Showing only the first N changes" with a pointer to raise the limit, instead of the lower-bound wording. Render the warning title as an Alert.Title child: the raw Alert.Root only set it as an HTML title attribute. Drop the old truncation strings from translated locales. Hide the table's "N Records" heading: the summary already counts the changes, and the record count could disagree with it, since a redacted record stands for every change sharing its path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes to the Dag version comparison (Versions tab):
Empty "Max changes" field no longer shows an error border. The number input treats an empty value as NaN, so zag's
isOutOfRangemarked the field's normal, unset state invalid.Versions.tsxnow passesinvalidexplicitly: only a non-empty value that is not an integer in 1..5000 is invalid.Clearer messaging when the limit cuts the comparison short.
versions.truncated.*strings are removed from the seven translated locales so they fall back to English rather than show the old meaning; translators can add the new keys.Comparison of two versions with more changes than the default limit (500), Max changes left empty.
Before (main):
After: