Repository navigation
[v3-4-test] Fix Dag version diff max-changes border, limit wording and duplicate count (#74818) - #74886
Merged
Conversation
…d duplicate count (#74818) An empty Max changes field parsed to NaN, which the number input treats as out of range, so its normal unset state drew an error border. Pass `invalid` explicitly so only a real out-of-range value is flagged. When the comparison hits the limit, say "At least N changes" and "Showing only the first N changes" with a pointer to raise the limit, instead of the lower-bound wording. Render the warning title as an Alert.Title child: the raw Alert.Root only set it as an HTML title attribute. Drop the old truncation strings from translated locales. Hide the table's "N Records" heading: the summary already counts the changes, and the record count could disagree with it, since a redacted record stands for every change sharing its path. (cherry picked from commit 23f4aee) Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
boring-cyborg
Bot
added
area:translations
area:UI
shahar1
marked this pull request as ready for review
October 16, 2026 18:44
shahar1
requested review from
Lee-W,
ashb,
bbovenzi,
bugraoz93,
choo121600,
guan404ming,
henry3260,
jason810496,
jscheffl,
mobuchowski,
pierrejeambrun,
potiuk,
ryanahamilton,
shubhamraj-git,
vatsrahul1001 and
vincbeck
as code owners
October 16, 2026 18:44
shahar1
approved these changes
Oct 16, 2026
choo121600
approved these changes
Oct 17, 2026
Contributor
Author
|
Hi maintainer, this PR was merged without a milestone set.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An empty Max changes field parsed to NaN, which the number input treats
as out of range, so its normal unset state drew an error border. Pass
invalidexplicitly so only a real out-of-range value is flagged.When the comparison hits the limit, say "At least N changes" and
"Showing only the first N changes" with a pointer to raise the limit,
instead of the lower-bound wording. Render the warning title as an
Alert.Title child: the raw Alert.Root only set it as an HTML title
attribute. Drop the old truncation strings from translated locales.
Hide the table's "N Records" heading: the summary already counts the
changes, and the record count could disagree with it, since a redacted
record stands for every change sharing its path.
(cherry picked from commit 23f4aee)
Co-authored-by: Jed Cunningham 66968678+jedcunningham@users.noreply.github.com