Repository navigation
[v3-4-test] Remove the gap above docs pages left from the old site banner (#75485) - #75487
Merged
Merged
Conversation
…nner (#75485) custom.css still padded the docs layout by 163px and offset anchor targets by 161px, sized for a 40px banner above a 121px navbar. The site now has no banner, a 90px navbar (80px at 1280px and below), and the theme already pads the body for the navbar, so docs content started 253px down instead of 130px. Drop the padding override so the theme's 40px applies, and size the anchor offset to the navbar plus the same 40px. (cherry picked from commit a5160a9) Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com>
Contributor
Author
|
Hi maintainer, this PR was merged without a milestone set.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
custom.css still padded the docs layout by 163px and offset anchor
targets by 161px, sized for a 40px banner above a 121px navbar. The site
now has no banner, a 90px navbar (80px at 1280px and below), and the
theme already pads the body for the navbar, so docs content started
253px down instead of 130px.
Drop the padding override so the theme's 40px applies, and size the
anchor offset to the navbar plus the same 40px.
(cherry picked from commit a5160a9)
Co-authored-by: Kaxil Naik kaxilnaik@gmail.com