Repository navigation
Remove the gap above docs pages left from the old site banner - #75485
Merged
Merged
Conversation
custom.css still padded the docs layout by 163px and offset anchor targets by 161px, sized for a 40px banner above a 121px navbar. The site now has no banner, a 90px navbar (80px at 1280px and below), and the theme already pads the body for the navbar, so docs content started 253px down instead of 130px. Drop the padding override so the theme's 40px applies, and size the anchor offset to the navbar plus the same 40px.
shahar1
approved these changes
Oct 23, 2026
Contributor
Backport successfully created: v3-4-testNote: As of Merging PRs targeted for Airflow 3.X In matter of doubt please ask in #release-management Slack channel.
|
kaxil
added a commit
that referenced
this pull request
Oct 23, 2026
…nner (#75485) (#75487) custom.css still padded the docs layout by 163px and offset anchor targets by 161px, sized for a 40px banner above a 121px navbar. The site now has no banner, a 90px navbar (80px at 1280px and below), and the theme already pads the body for the navbar, so docs content started 253px down instead of 130px. Drop the padding override so the theme's 40px applies, and size the anchor offset to the navbar plus the same 40px. (cherry picked from commit a5160a9) Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docs pages start with a large empty band under the navbar. On airflow.apache.org, the content of a docs page begins 253px from the top of the window; the theme lays it out at 130px.
The cause is
devel-common/sphinx_design/static/custom.css, which pads.base-layoutby163px !important("banner + navbar + 2px padding") and offsets anchor targets by 161px (117px at 1280px and below). Those values date from #52016, when the site had a 40px banner above a 121px navbar. Since then airflow-site removed the banner and shrank the navbar to 90px (80px at 1280px and below), and the theme now padsbodyfor the navbar and gives.base-layoutits own 40px. The override stacks 163px on top of that.This removes the
.base-layoutoverride, so the theme's 40px applies, and sizes the anchor offset to the navbar plus the same 40px: 130px, or 120px at 1280px and below.At 1100px wide, content moves from 297px to 174px and anchored headings land at 121px instead of 126px.
The right-hand "On this page" list is still pinned 263px from the top by a separate rule in the theme, so with only this change it sits lower than the content. apache/airflow-site#1701 fixes that.
Top of the docs index and the same page scrolled, at 1728px in dark mode. "Before" is airflow.apache.org. "After" is a local
breezedocs build with #75485 and apache/airflow-site#1701 (theme wheel built from that branch):