Repository navigation
Document all Google Cloud connection fields - #76160
Merged
Merged
Conversation
Five fields shown in the Google Cloud connection form, covering anonymous credentials and the external IdP Client Credentials Grant flow, had no description, and the list of keys accepted when defining the connection as a URI or JSON stopped at num_retries. Users configuring the connection from environment variables or secrets backends had to read the hook source to discover those keys.
shahar1
approved these changes
Oct 31, 2026
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Google Cloud connection page did not describe five fields shown in the connection form
(anonymous credentials and the four fields of the external IdP Client Credentials Grant
flow), and the list of keys accepted when defining the connection as a URI or JSON stopped
at
num_retries. Users configuring the connection through environment variables or asecrets backend had to read
GoogleBaseHookto discovercredential_config_file,impersonation_chain,quota_project_id,is_anonymous,idp_issuer_url,client_id,client_secretandidp_extra_parameters.The new descriptions follow
GoogleBaseHookand_CredentialProvider, including which keyoptions are mutually exclusive with anonymous credentials.
The hook currently ignores
idp_extra_parameters; the companion PR "Fix Google Cloudconnection IdP extra request parameters being ignored" fixes that, so it is best merged first.
Was generative AI tooling used to co-author this PR?
Generated-by: Code Puppy following the guidelines