Skip to content

GH-49076: [CI] Update vcpkg baseline to newer version #49062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
raulcd wants to merge 4 commits into
base: main
Choose a base branch
from
Open

GH-49076: [CI] Update vcpkg baseline to newer version #49062

raulcd wants to merge 4 commits into from
+6 −9

Conversation

@raulcd
Copy link
Member

@raulcd raulcd commented Jan 29, 2026 •
edited by github-actions bot
Loading

Rationale for this change

The current version of vcpkg used is a from April 2025

What changes are included in this PR?

Update baseline to newer version.

Are these changes tested?

Yes on CI. I've validated for example that xsimd 14 will be pulled.

Are there any user-facing changes?

No

@raulcd raulcd changed the title WIP: [CI] Try updating vcpkg baseline MINOR: [CI] Try updating vcpkg baseline Jan 29, 2026
@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Jan 29, 2026
@raulcd raulcd force-pushed the update-vcpkg-baseline branch from ca3fc65 to 8c54b77 Compare January 29, 2026 16:19
@raulcd raulcd force-pushed the update-vcpkg-baseline branch from 40c16b8 to 10803ea Compare January 29, 2026 16:44
@raulcd raulcd mentioned this pull request Jan 29, 2026
Open
raulcd
raulcd commented Jan 29, 2026
View reviewed changes
cpp/vcpkg.json
Comment on lines -45 to -49
"name": "gtest",
"features": [
"cxx17"
]
},
Copy link
Member Author

@raulcd raulcd Jan 29, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't necessary anymore since:
microsoft/vcpkg@b00ff11

Copy link
Contributor

@AntoinePrv AntoinePrv Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually should we add cxx20?

Copy link
Member Author

@raulcd raulcd Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, this was removed. There's no additional features on vcpkg anymore. You can see that on the commit above. This is how the current port file looks (no features):
https://github.com/microsoft/vcpkg/blob/master/ports/gtest/vcpkg.json

@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting committer review Awaiting committer review labels Jan 29, 2026
@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Jan 29, 2026
@raulcd raulcd changed the title MINOR: [CI] Try updating vcpkg baseline GH-49076: [CI] Try updating vcpkg baseline Jan 30, 2026
@github-actions
Copy link

github-actions bot commented Jan 30, 2026

⚠️ GitHub issue #49076 has been automatically assigned in GitHub to PR creator.

@AntoinePrv
Copy link
Contributor

AntoinePrv commented Jan 30, 2026

Should we merge this or integrate it in #48765 ?

@raulcd
Copy link
Member Author

raulcd commented Jan 30, 2026

Should we merge this or integrate it in #48765 ?

I am fine with both. I was just putting it into a mergeable state but tbh the change is quite minor so I am happy if it gets integrated with your PR.

@raulcd raulcd changed the title GH-49076: [CI] Try updating vcpkg baseline GH-49076: [CI] Update vcpkg baseline to newer version Jan 30, 2026
@raulcd raulcd marked this pull request as ready for review January 30, 2026 09:18
@raulcd raulcd requested a review from kou as a code owner January 30, 2026 09:18
@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting change review Awaiting change review labels Jan 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kou kou Awaiting requested review from kou kou is a code owner

1 more reviewer

@AntoinePrv AntoinePrv AntoinePrv left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

awaiting changes Awaiting changes Component: C++ Component: GLib

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@raulcd @AntoinePrv