Conversation
|
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/oap-project/gluten/issues Then could you also rename commit message and pull request title in the following format? See also: |
0bda556 to
51b8a23
Compare
|
Spark plan: Return result: |
|
Native arrayJoin in clickhouse backend is almost 3x faster than Spark explode. |
da78f5c to
59a7ffc
Compare
d49b883 to
483ef72
Compare
|
@rui-mo Can you help review this pr, thanks! |
gluten-core/src/main/scala/io/glutenproject/execution/GenerateExecTransformer.scala
Show resolved
Hide resolved
|
@rui-mo It it possible running gluten CI/CD with clickhouse version binding to Kyligence/ClickHouse#194 ? |
Sure. I think it is OK. |
235aa3c to
f073390
Compare
6f5a016 to
aedfd5f
Compare
gluten-core/src/main/scala/io/glutenproject/expression/ArrayExpressionTransformer.scala
Outdated
Show resolved
Hide resolved
gluten-core/src/main/scala/io/glutenproject/expression/ArrayExpressionTransformer.scala
Outdated
Show resolved
Hide resolved
gluten-core/src/main/scala/io/glutenproject/expression/UnaryExpressionTransformer.scala
Outdated
Show resolved
Hide resolved
gluten-core/src/main/resources/substrait/proto/substrait/algebra.proto
Outdated
Show resolved
Hide resolved
gluten-core/src/main/scala/io/glutenproject/expression/ArrayExpressionTransformer.scala
Outdated
Show resolved
Hide resolved
gluten-core/src/main/scala/io/glutenproject/expression/UnaryExpressionTransformer.scala
Outdated
Show resolved
Hide resolved
| import io.glutenproject.expression.ExpressionMappings._ | ||
|
|
||
| object CHExpressionUtil { | ||
|
|
75fcb44 to
2d5246c
Compare
| RelCommon common = 1; | ||
| Rel input = 2; | ||
|
|
||
| Expression generator = 3; |
There was a problem hiding this comment.
Should this relation be removed in favor of the official Substrait repo's ExpandRel?
There was a problem hiding this comment.
GenerateRel and ExpandRel is different. The former is used to represent spark lateral view explode/posexpode, and the latter is used to represent spark grouping sets or with cube
What changes were proposed in this pull request?
Support generate exec. close Kyligence/ClickHouse#191
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)
test by CH[[194]]