Skip to content

[CH-212] support map[key] and array[index] expression#609

Merged
lviiii merged 2 commits intoapache:mainfrom
bigo-sg:gluten_212
Dec 15, 2022
Merged

[CH-212] support map[key] and array[index] expression#609
lviiii merged 2 commits intoapache:mainfrom
bigo-sg:gluten_212

Conversation

@taiyang-li
Copy link
Copy Markdown
Contributor

@taiyang-li taiyang-li commented Nov 24, 2022

What changes were proposed in this pull request?

(Please fill in changes proposed in this fix)

How was this patch tested?

(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)

(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

test by CH[[216]]

@github-actions
Copy link
Copy Markdown

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/oap-project/gluten/issues

Then could you also rename commit message and pull request title in the following format?

[Gluten-${ISSUES_ID}] ${detailed message}

See also:

@taiyang-li taiyang-li marked this pull request as ready for review November 24, 2022 15:03
@taiyang-li taiyang-li marked this pull request as draft December 5, 2022 02:53
@taiyang-li
Copy link
Copy Markdown
Contributor Author

Waiting for #574 to be merged.

@taiyang-li taiyang-li marked this pull request as ready for review December 13, 2022 07:19
Copy link
Copy Markdown
Contributor

@zzcclp zzcclp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zzcclp zzcclp requested a review from lviiii December 15, 2022 07:37
Copy link
Copy Markdown
Contributor

@lviiii lviiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants