Change tagged job assignment behavior#2976
Merged
Merged
Conversation
xyuanlu
approved these changes
Dec 5, 2024
Once tag removed from instance for assignment purpose, current behavior is: 1) no new tagged tasks assigns to that instance. 2) drop the existing running tasks. Change behavior for this: 1) keep no new tagged tasks assigns to that instance. 2) let existing tasks running to complete Test added.
|
@junkaixue , when can we cut a Helix release? |
zpinto
pushed a commit
to zpinto/helix
that referenced
this pull request
Jan 22, 2025
Once tag removed from instance for assignment purpose, current behavior is: 1) no new tagged tasks assigns to that instance. 2) drop the existing running tasks. Change behavior for this: 1) keep no new tagged tasks assigns to that instance. 2) let existing tasks running to complete Test added. Co-authored-by: Junkai <jxue@pinterest.com>
|
@junkaixue @xyuanlu is it possible to hotfix this fix into a 1.3.* Helix version so that we can get this fix without the full 1.4+ Helix upgrade? |
asf-gitbox-commits
pushed a commit
that referenced
this pull request
Jun 18, 2025
Once tag removed from instance for assignment purpose, current behavior is: 1) no new tagged tasks assigns to that instance. 2) drop the existing running tasks. Change behavior for this: 1) keep no new tagged tasks assigns to that instance. 2) let existing tasks running to complete Test added. Co-authored-by: Junkai <jxue@pinterest.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
Description
Once tag removed from instance for assignment purpose, current behavior is: 1) no new tagged tasks assigns to that instance.
2) drop the existing running tasks.
Change behavior for this:
Test added.
Tests
The following tests are written for this issue:
AfterClass: TestJobTagRemoval called.
Shut down zookeeper at port 2183 in thread main
Default Suite
Total tests run: 1, Failures: 0, Skips: 0
The following is the result of the "mvn test" command on the appropriate module:
Changes that Break Backward Compatibility (Optional)
(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)
Documentation (Optional)
(Link the GitHub wiki you added)
Commits
Code Quality
(helix-style-intellij.xml if IntelliJ IDE is used)