Upgrade Helix version to 1.3.2#16239
Merged
Merged
Conversation
Jackie-Jiang
approved these changes
Jun 30, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #16239 +/- ##
============================================
+ Coverage 62.90% 63.18% +0.28%
+ Complexity 1386 1362 -24
============================================
Files 2867 2959 +92
Lines 163354 170860 +7506
Branches 24952 26151 +1199
============================================
+ Hits 102755 107966 +5211
- Misses 52847 54716 +1869
- Partials 7752 8178 +426
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade the Helix version to 1.3.2
Helix 1.3.2 branch: https://github.com/apache/helix/tree/helix-1.3.2
Helix 1.3.2 commits: https://github.com/apache/helix/commits/helix-1.3.2/
The main motivation for making this update is to pull in this fix from the Helix side: apache/helix#2976
Today we see an issue with Minions where if the Minion is not gracefully shutdown (even if the tag is removed), Helix can drop the tasks assigned to that minion. With the above changes, Helix will wait for the tasks to complete.
Testing done:
mvn clean install -DskipTests -Pbin-dist