Implement session timeout #3483
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… # server/src/main/java/org/apache/iotdb/db/qp/constant/SQLConstant.java # server/src/main/java/org/apache/iotdb/db/qp/logical/Operator.java # server/src/main/java/org/apache/iotdb/db/qp/sql/IoTDBSqlVisitor.java
… # server/src/main/java/org/apache/iotdb/db/qp/constant/SQLConstant.java # server/src/main/java/org/apache/iotdb/db/qp/logical/Operator.java # server/src/main/java/org/apache/iotdb/db/qp/sql/IoTDBSqlVisitor.java
…-manager # Conflicts: # server/src/main/java/org/apache/iotdb/db/query/control/SessionManager.java # server/src/main/java/org/apache/iotdb/db/service/TSServiceImpl.java
Alima777
reviewed
Jul 2, 2021
server/src/main/java/org/apache/iotdb/db/query/control/SessionTimeoutManager.java
Outdated
Show resolved
Hide resolved
Alima777
approved these changes
Jul 5, 2021
server/src/main/java/org/apache/iotdb/db/query/control/SessionTimeoutManager.java
Outdated
Show resolved
Hide resolved
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users may forget to close sessions. Such idle connections lead to a waste of server resource and in the worst case, take up all the memory of server. To solve this problem, we would like to introduce session timeout.
Design
SessionTimeoutManagermanages the lifecycle of all sessions. It keeps track of the last active time of the sessionsand periodically checks if the current running sessions have timed out. Specifically, if a session has been idle for a configurable period of time,
SessionTimeoutManagerwill consider it as timed out and ends the session forcibly.Session timeouts are refreshed under the following scenarios:
checkLoginis called. Effectively, session timeout is refreshed whenever a new query/non-query operations comes in.QueryTimeManager.