[To rel/0.13] [IOTDB-3943] Optimize session timeout feature #6783
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
fix the issue of session timeout |
liuminghui233
changed the title
liuminghui233
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
HTHou
approved these changes
Jul 27, 2022
HTHou
reviewed
Jul 27, 2022
server/src/main/java/org/apache/iotdb/db/query/control/SessionTimeoutManager.java
Outdated
Show resolved
Hide resolved
…TimeoutManager.java Co-authored-by: Haonan <[email protected]>
qiaojialin
reviewed
Jul 27, 2022
server/src/main/java/org/apache/iotdb/db/query/control/SessionTimeoutManager.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/apache/iotdb/db/service/basic/ServiceProvider.java
Show resolved
Hide resolved
service-rpc/src/main/java/org/apache/iotdb/rpc/SessionTimeoutException.java
Show resolved
Hide resolved
HTHou
approved these changes
Jul 28, 2022
This was referenced Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Users may forget to close sessions. Such idle connections lead to a waste of server resource and in the worst case, take up all the memory of server. Session timeout is trying to solve such problem.
#3483
Currently this feature has other problems
Once the session is cleared by session timeout, the client will not get the status, when client tries to use the session again, server will throw NPE. We should throw connect exception here to client, so that session pool can catch it and uses another session to connect.
Metric module will insert data to IoTDB, we need to consider use session pool in this module.
This PR has:
for an unfamiliar reader.
for code coverage.
Key changed/added classes (or packages if there are too many classes) in this PR