[issue 679][oauth2] Fix macos compiler warnings#719
Merged
merlimat merged 1 commit intoapache:masterfrom Feb 9, 2022
Merged
Conversation
c31c397 to
f7a247b
Compare
This upgrades the 99designs/keyring dependency to v1.2.0 in the oauth2 submodule in order to remove the compiler deprecation warnings on macos. Signed-off-by: Paul Gier <paul.gier@datastax.com>
f7a247b to
8096f45
Compare
|
Thank you for submitting this PR! Hope it can be merged soon, since other downstream projects are facing build errors because of this issue. |
cckellogg
approved these changes
Feb 9, 2022
merlimat
approved these changes
Feb 9, 2022
|
I have studied the source code of pulsar OAuth2 sub mod project. |
1 task
This was referenced Apr 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This upgrades the dependency from the oauth2 module to 99designs/keyring to remove the compiler warnings on macos.
Fixes #679
Fixes #626
Fixes #594
See also 99designs/keyring#102
Motivation
Explain here the context, and why you're making that change. What is the problem you're trying to solve.
Building on recent versions of OSX/MacOS outputs the following compiler warnings.
Modifications
The warnings are coming from the dependency on 99designs/keyring. This PR upgrades to the latest master of that project in order to remove the compiler warnings, and avoid some potential build failures as described in #679
Verifying this change
This change is already covered by existing tests, such as (please describe tests).
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation