Update github.com/apache/pulsar-client-go/oauth2#1130
Merged
Jeffail merged 1 commit intoredpanda-data:masterfrom Feb 13, 2022
Merged
Update github.com/apache/pulsar-client-go/oauth2#1130Jeffail merged 1 commit intoredpanda-data:masterfrom
Jeffail merged 1 commit intoredpanda-data:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #999.
apache/pulsar-client-go#719 has been merged, yay! I seem to be a bit confused on how go modules work here and why isn't the version of
github.com/apache/pulsar-client-go/oauth2tied to thegit.832008.xyz/apache/pulsar-client-goversion... Initially, I was expecting to have to updategit.832008.xyz/apache/pulsar-client-go, but they haven't pushed a new tag yet, so I tried to just update this inner package, since I noticed the Benthosgo.modreferences it explicitly. I see they have this replace directive here, but not sure if that has anything to do with it.Anyhow, the build works fine now and the integration tests pass.