-
Notifications
You must be signed in to change notification settings - Fork 669
Add support for RESTEasy 6.x #587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
apm-sniffer/apm-sdk-plugin/resteasy-plugin/resteasy-server-6.x-plugin/pom.xml
Outdated
Show resolved
Hide resolved
...ache/skywalking/apm/plugin/resteasy/v6/server/SynchronousDispatcherExceptionInterceptor.java
Outdated
Show resolved
Hide resolved
…er-6.x-plugin's compiler version to jdk11
|
@wu-sheng btw, when will skywalking 9.0.0 be released? |
|
At least end of next month, the last 8.x released last month. |
|
|
||
| public class SynchronousDispatcherInstrumentation extends ClassInstanceMethodsEnhancePluginDefine { | ||
|
|
||
| private static final String ENHANCE_CLASS = "org.jboss.resteasy.core.SynchronousDispatcher"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Leibnizhu We received a report from slack that all v3/v4/v6 plugins of RESTEasy are using the same target class without witness class. It seems to have conflicts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where can I find more information related to witness class ? or in other words, how should I fix it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Read point 4 here.
Witness class is using version specific class names or methods to separate versions in the runtime.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed it in PR #722
Add an agent plugin to support RESTEasy 6.x
Add a test case for the new plugin, refer to the doc
Add a component id in the component-libraries.yml
Add a logo in the UI repo
If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes : NO
Update the
CHANGESlog.Skywalking already supports Resteasy 3.x and 4.x. Referrers to RESTEASY-3007, Resteasy 6 has migrated from Jakarta REST 2.1 to Jakarta REST 3.0.
Therefore, when applying skywalking's Resteasy 4.x javaagent to a Resteasy 6.x application, it throws
NoSuchMethodErrorlike belows:this PR:
support-version.list)