-
Notifications
You must be signed in to change notification settings - Fork 689
Add a plugin that supports the Solon framework. #697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 40 commits
be675c2
06732e8
924c61f
ffd56db
dbd24b4
0b2afff
b96e8c5
88ef3ca
0716d24
1704f4d
0d32357
47eb826
c77ba51
4b772bf
b68aa80
62884f5
c05c8f8
05bc9e5
ae6c7cf
d253974
20a3507
2b72e14
8fcb404
a8cb8c3
f6ffd0e
3ace531
53b9c5a
ca6ff8b
c205c1a
4b5e558
5fbdc2a
4982488
916dc21
505e99c
115727f
24799a6
22a4a8f
3524717
160668c
08bdfcb
38cb7b1
193b532
20c3545
9f3392e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| <?xml version="1.0"?> | ||
| <!-- | ||
| ~ Licensed to the Apache Software Foundation (ASF) under one or more | ||
| ~ contributor license agreements. See the NOTICE file distributed with | ||
| ~ this work for additional information regarding copyright ownership. | ||
| ~ The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| ~ (the "License"); you may not use this file except in compliance with | ||
| ~ the License. You may obtain a copy of the License at | ||
| ~ | ||
| ~ http://www.apache.org/licenses/LICENSE-2.0 | ||
| ~ | ||
| ~ Unless required by applicable law or agreed to in writing, software | ||
| ~ distributed under the License is distributed on an "AS IS" BASIS, | ||
| ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| ~ See the License for the specific language governing permissions and | ||
| ~ limitations under the License. | ||
| ~ | ||
| --> | ||
|
|
||
| <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> | ||
| <modelVersion>4.0.0</modelVersion> | ||
| <parent> | ||
| <artifactId>apm-sdk-plugin</artifactId> | ||
| <groupId>org.apache.skywalking</groupId> | ||
| <version>9.3.0-SNAPSHOT</version> | ||
| </parent> | ||
|
|
||
| <artifactId>solon-2.x-plugin</artifactId> | ||
| <packaging>jar</packaging> | ||
|
|
||
| <name>solon-2.x-plugin</name> | ||
| <url>http://maven.apache.org</url> | ||
|
|
||
| <properties> | ||
| <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> | ||
| <apache-httpclient.version>4.3</apache-httpclient.version> | ||
| <junit.version>4.12</junit.version> | ||
| </properties> | ||
|
|
||
| <dependencies> | ||
| <dependency> | ||
| <groupId>org.noear</groupId> | ||
| <artifactId>solon-lib</artifactId> | ||
| <version>2.8.3</version> | ||
| <scope>provided</scope> | ||
| </dependency> | ||
| </dependencies> | ||
| </project> |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,111 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| * | ||
| */ | ||
|
|
||
| package org.apache.skywalking.apm.plugin.solon; | ||
|
|
||
| import lombok.extern.slf4j.Slf4j; | ||
| import org.apache.skywalking.apm.agent.core.context.CarrierItem; | ||
| import org.apache.skywalking.apm.agent.core.context.ContextCarrier; | ||
| import org.apache.skywalking.apm.agent.core.context.ContextManager; | ||
| import org.apache.skywalking.apm.agent.core.context.tag.Tags; | ||
| import org.apache.skywalking.apm.agent.core.context.trace.AbstractSpan; | ||
| import org.apache.skywalking.apm.agent.core.context.trace.SpanLayer; | ||
| import org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.EnhancedInstance; | ||
| import org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.v2.InstanceMethodsAroundInterceptorV2; | ||
| import org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.v2.MethodInvocationContext; | ||
| import org.apache.skywalking.apm.network.trace.component.ComponentsDefine; | ||
| import org.apache.skywalking.apm.util.StringUtil; | ||
| import org.noear.solon.core.NvMap; | ||
| import org.noear.solon.core.handle.Context; | ||
|
|
||
| import java.lang.reflect.Method; | ||
|
|
||
| @Slf4j | ||
| public class SolonActionExecuteInterceptor implements InstanceMethodsAroundInterceptorV2 { | ||
|
|
||
| @Override | ||
| public void beforeMethod(EnhancedInstance objInst, Method method, Object[] allArguments, Class<?>[] argumentsTypes, MethodInvocationContext context) throws Throwable { | ||
| Context ctx = (Context) allArguments[0]; | ||
| ContextCarrier contextCarrier = new ContextCarrier(); | ||
| CarrierItem next = contextCarrier.items(); | ||
| while (next.hasNext()) { | ||
| next = next.next(); | ||
| next.setHeadValue(ctx.header(next.getHeadKey())); | ||
| } | ||
| String operationName = "Solon:" + ctx.method() + ":" + ctx.path(); | ||
| AbstractSpan span = ContextManager.createEntrySpan(operationName, contextCarrier); | ||
| span.setComponent(ComponentsDefine.SOLON_MVC); | ||
|
wu-sheng marked this conversation as resolved.
wu-sheng marked this conversation as resolved.
|
||
| SpanLayer.asHttp(span); | ||
| Tags.URL.set(span, ctx.url()); | ||
| Tags.HTTP.METHOD.set(span, ctx.method()); | ||
| if (SolonPluginConfig.Plugin.Solon.HTTP_HEADERS_LENGTH_THRESHOLD != 0) { | ||
| String headerStr = "{}"; | ||
| if (SolonPluginConfig.Plugin.Solon.INCLUDE_HTTP_HEADERS != null && !SolonPluginConfig.Plugin.Solon.INCLUDE_HTTP_HEADERS.isEmpty()) { | ||
| NvMap includeHeaders = new NvMap(); | ||
| for (String header : SolonPluginConfig.Plugin.Solon.INCLUDE_HTTP_HEADERS) { | ||
| String value = ctx.header(header); | ||
| if (StringUtil.isNotBlank(value)) { | ||
| includeHeaders.put(header, value); | ||
| } | ||
| } | ||
| headerStr = includeHeaders.toString(); | ||
| } | ||
| if (SolonPluginConfig.Plugin.Solon.HTTP_HEADERS_LENGTH_THRESHOLD > 0 && headerStr.length() > SolonPluginConfig.Plugin.Solon.HTTP_HEADERS_LENGTH_THRESHOLD) { | ||
| headerStr = headerStr.substring(0, SolonPluginConfig.Plugin.Solon.HTTP_HEADERS_LENGTH_THRESHOLD); | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You should control header by key list, because every key has a length limitation by HTTP. Once the number of keys is limited, we don't need to worry about overload. |
||
| } | ||
| Tags.HTTP.HEADERS.set(span, headerStr); | ||
| } | ||
| if (SolonPluginConfig.Plugin.Solon.HTTP_BODY_LENGTH_THRESHOLD != 0) { | ||
| String body = ctx.body(); | ||
| if (StringUtil.isNotBlank(body)) { | ||
| if (SolonPluginConfig.Plugin.Solon.HTTP_BODY_LENGTH_THRESHOLD > 0 && body.length() > SolonPluginConfig.Plugin.Solon.HTTP_BODY_LENGTH_THRESHOLD) { | ||
| body = body.substring(0, SolonPluginConfig.Plugin.Solon.HTTP_BODY_LENGTH_THRESHOLD); | ||
| } | ||
| Tags.HTTP.BODY.set(span, body); | ||
| } | ||
| } | ||
| if (SolonPluginConfig.Plugin.Solon.HTTP_PARAMS_LENGTH_THRESHOLD != 0) { | ||
| String param = ctx.paramMap().toString(); | ||
| if (SolonPluginConfig.Plugin.Solon.HTTP_PARAMS_LENGTH_THRESHOLD > 0 && param.length() > SolonPluginConfig.Plugin.Solon.HTTP_PARAMS_LENGTH_THRESHOLD) { | ||
| param = param.substring(0, SolonPluginConfig.Plugin.Solon.HTTP_PARAMS_LENGTH_THRESHOLD); | ||
| } | ||
| Tags.HTTP.PARAMS.set(span, param); | ||
| } | ||
| } | ||
|
|
||
| @Override | ||
| public Object afterMethod(EnhancedInstance objInst, Method method, Object[] allArguments, Class<?>[] argumentsTypes, Object ret, MethodInvocationContext context) { | ||
| Context ctx = (Context) allArguments[0]; | ||
| Tags.HTTP_RESPONSE_STATUS_CODE.set(ContextManager.activeSpan(), ctx.status()); | ||
|
wu-sheng marked this conversation as resolved.
|
||
| if (ctx.errors != null && context.getContext() == null) { | ||
| AbstractSpan activeSpan = ContextManager.activeSpan(); | ||
| activeSpan.errorOccurred(); | ||
| activeSpan.log(ctx.errors); | ||
| } | ||
| ContextManager.stopSpan(); | ||
| return ret; | ||
| } | ||
|
|
||
| @Override | ||
| public void handleMethodException(EnhancedInstance objInst, Method method, Object[] allArguments, Class<?>[] argumentsTypes, Throwable t, MethodInvocationContext context) { | ||
| AbstractSpan activeSpan = ContextManager.activeSpan(); | ||
| activeSpan.errorOccurred(); | ||
| activeSpan.log(t); | ||
| context.setContext(true); | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| * | ||
| */ | ||
|
|
||
| package org.apache.skywalking.apm.plugin.solon; | ||
|
|
||
| import org.apache.skywalking.apm.agent.core.boot.PluginConfig; | ||
|
|
||
| import java.util.List; | ||
|
|
||
| public class SolonPluginConfig { | ||
| public static class Plugin { | ||
| @PluginConfig(root = SolonPluginConfig.class) | ||
| public static class Solon { | ||
| /** | ||
| * Define the max length of collected HTTP parameters. The default value(=0) means not collecting. | ||
| */ | ||
| public static int HTTP_PARAMS_LENGTH_THRESHOLD = 0; | ||
| /** | ||
| * Define the max length of collected HTTP header. The default value(=0) means not collecting. | ||
| */ | ||
| public static int HTTP_HEADERS_LENGTH_THRESHOLD = 0; | ||
| /** | ||
| * Define the max length of collected HTTP body. The default value(=0) means not collecting. | ||
| */ | ||
| public static int HTTP_BODY_LENGTH_THRESHOLD = 0; | ||
| /** | ||
| * It controls what header data should be collected, values must be in lower case, if empty, no header data will be collected. default is empty. | ||
| */ | ||
| public static List<String> INCLUDE_HTTP_HEADERS ; | ||
| } | ||
| } | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,66 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| * | ||
| */ | ||
|
|
||
| package org.apache.skywalking.apm.plugin.solon.define; | ||
|
|
||
| import net.bytebuddy.description.method.MethodDescription; | ||
| import net.bytebuddy.matcher.ElementMatcher; | ||
| import org.apache.skywalking.apm.agent.core.plugin.interceptor.ConstructorInterceptPoint; | ||
| import org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.v2.ClassInstanceMethodsEnhancePluginDefineV2; | ||
| import org.apache.skywalking.apm.agent.core.plugin.interceptor.v2.InstanceMethodsInterceptV2Point; | ||
| import org.apache.skywalking.apm.agent.core.plugin.match.ClassMatch; | ||
| import org.apache.skywalking.apm.agent.core.plugin.match.NameMatch; | ||
|
|
||
| import static net.bytebuddy.matcher.ElementMatchers.named; | ||
|
|
||
| public class SolonActionInstrumentation extends ClassInstanceMethodsEnhancePluginDefineV2 { | ||
|
|
||
| private static final String INTERCEPT_CLASS = "org.apache.skywalking.apm.plugin.solon.SolonActionExecuteInterceptor"; | ||
|
|
||
| @Override | ||
| public ClassMatch enhanceClass() { | ||
| return NameMatch.byName("org.noear.solon.SolonApp"); | ||
| } | ||
|
|
||
| @Override | ||
| public ConstructorInterceptPoint[] getConstructorsInterceptPoints() { | ||
| return new ConstructorInterceptPoint[0]; | ||
| } | ||
|
|
||
| @Override | ||
| public InstanceMethodsInterceptV2Point[] getInstanceMethodsInterceptV2Points() { | ||
| return new InstanceMethodsInterceptV2Point[] { | ||
| new InstanceMethodsInterceptV2Point() { | ||
| @Override | ||
| public ElementMatcher<MethodDescription> getMethodsMatcher() { | ||
| return named("tryHandle"); | ||
| } | ||
|
|
||
| @Override | ||
| public String getMethodsInterceptorV2() { | ||
| return INTERCEPT_CLASS; | ||
| } | ||
|
|
||
| @Override | ||
| public boolean isOverrideArgs() { | ||
| return true; | ||
| } | ||
| } | ||
| }; | ||
| } | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| # Licensed to the Apache Software Foundation (ASF) under one | ||
| # or more contributor license agreements. See the NOTICE file | ||
| # distributed with this work for additional information | ||
| # regarding copyright ownership. The ASF licenses this file | ||
| # to you under the Apache License, Version 2.0 (the | ||
| # "License"); you may not use this file except in compliance | ||
| # with the License. You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| solon-2.x=org.apache.skywalking.apm.plugin.solon.define.SolonActionInstrumentation |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -320,3 +320,11 @@ plugin.nettyhttp.supported_content_types_prefix=${SW_PLUGIN_NETTYHTTP_SUPPORTED_ | |
| plugin.rocketmqclient.collect_message_keys=${SW_PLUGIN_ROCKETMQCLIENT_COLLECT_MESSAGE_KEYS:false} | ||
| # If set to true, the tags of messages would be collected by the plugin for RocketMQ Java client. | ||
| plugin.rocketmqclient.collect_message_tags=${SW_PLUGIN_ROCKETMQCLIENT_COLLECT_MESSAGE_TAGS:false} | ||
| # Define the max length of collected HTTP parameters. The default value(=0) means not collecting. | ||
| plugin.solon.http_params_length_threshold=${SW_PLUGIN_SOLON_HTTP_PARAMS_LENGTH_THRESHOLD:0} | ||
| # Define the max length of collected HTTP header. The default value(=0) means not collecting. | ||
| plugin.solon.http_headers_length_threshold=${SW_PLUGIN_SOLON_HTTP_HEADERS_LENGTH_THRESHOLD:0} | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This config field doesn't exist in the codes. Why it is here? |
||
| # It controls what header data should be collected, values must be in lower case, if empty, no header data will be collected. default is empty. | ||
| plugin.solon.include_http_headers=${SW_PLUGIN_SOLON_INCLUDE_HTTP_HEADERS:} | ||
| # Define the max length of collected HTTP body. The default value(=0) means not collecting. | ||
| plugin.solon.http_body_length_threshold=${SW_PLUGIN_SOLON_HTTP_BODY_LENGTH_THRESHOLD:0} | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -177,3 +177,4 @@ | |
| - spring-webflux-6.x-webclient | ||
| - activemq-artemis-jakarta-client-2.x | ||
| - c3p0-0.9.x | ||
| - solon-2.x | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The operation name of the span should be framework stack irrelevant. And you need to change test cases accordingly.