[SPARK-55402][SS] Move streamingSourceIdentifyingName from CatalogTable to DataSource#54185
Open
ericm-db wants to merge 2 commits intoapache:masterfrom
Open
[SPARK-55402][SS] Move streamingSourceIdentifyingName from CatalogTable to DataSource#54185ericm-db wants to merge 2 commits intoapache:masterfrom
ericm-db wants to merge 2 commits intoapache:masterfrom
Conversation
JIRA Issue Information=== Task SPARK-55402 === This comment was automatically generated by GitHub Actions |
brkyvz
approved these changes
Feb 6, 2026
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR refactors the streamingSourceIdentifyingName field to move it from CatalogTable into DataSource as a constructor parameter. The changes include:
Why are the changes needed?
streamingSourceIdentifyingName represents query-specific metadata (which source name was assigned in a particular streaming query plan), not an intrinsic property of the table itself. Storing it in CatalogTable breaks table equality semantics:
By moving this field to DataSource (which is already query-specific), we restore proper catalog table equality while maintaining the ability to track streaming source identifying names for stable checkpoints.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Unit tests
Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Opus 4.6