Merged
Conversation
Contributor
Author
|
Please ignore API breakage, known to fail when making changes like this, but safe to land: |
This was referenced Jul 14, 2023
Contributor
Author
|
@swift-server-bot test this please |
Contributor
Author
|
The changes to the code are good, but not adding the enforcement yet until apple/swift-openapi-generator#119 |
Contributor
Author
|
Ok Integration Test passes again. |
Collaborator
|
Rather than just disable it everywhere, let's enable it in just the Swift 5.9+ builds, by adding This way we won't regress. |
simonjbeaumont
approved these changes
Jul 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
As a follow-on to apple/swift-openapi-generator#99, let's also enable explicit existential any in the runtime library.
Modifications
Enabled the flag in Package.swift (for Swift 5.9 and newer) and updated all the usage sites.
Result
The codebase is closer to being ready for Swift 6.
Test Plan
Updated unit tests as well, all is passing locally.