Conversation
- Update csstype version in package.json, packages/jest/package.json, and packages/react/package.json - Update AtRules type mapping in babel-plugin to reflect csstype 3.2.3 changes: - Remove @scroll-timeline (abandoned CSS proposal) - Remove @Viewport (obsolete, no modern browser support) - Add @container (CSS Container Queries) - Add @position-try (CSS Anchor Positioning) - Add @view-transition (View Transitions API) - Add changeset documenting the upgrade and rationale
Zerowxm
requested review from
JakeLane,
danieldelcore,
dddlr,
kylorhall-atlassian,
liamqma and
pancaspe87
as code owners
🦋 Changeset detectedLatest commit: 7a89b56 The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for compiled-css-in-js canceled.
|
| '@scroll-timeline': true, | ||
| '@starting-style': true, | ||
| '@supports': true, | ||
| '@viewport': true, |
There was a problem hiding this comment.
This and scroll-timeline have been removed, but do we use it internally? Is this a breaking change or does no one use this at all? It's deprecated, so I could see it.
There was a problem hiding this comment.
Your changeset had a good description, I think it's fair.
|
|
||
| const atRules: Record<AtRules, boolean> = { | ||
| '@charset': true, | ||
| '@container': true, |
There was a problem hiding this comment.
I'm pretty certain we had container queries 🤔 what does this atRules do today? Does this result in sorting? If we're changing sorting, we might need to update website docs, not 100% certain.
| @@ -0,0 +1,20 @@ | |||
| --- | |||
| "@compiled/babel-plugin": minor | |||
There was a problem hiding this comment.
This might need to be contributed to https://github.com/atlassian-labs/atlaspack/blob/main/crates/atlassian-swc-compiled-css/src/postcss/plugins/sort-atomic-style-sheet.rs (or thereabouts) as well.
cc: @JakeLane when he gets back
…container fix - Clarify that @container was partially supported but missing from cssMap validation - Explain what the atRules lookup table does - Update version bumps to minor for babel-plugin (new @container support) - Add detailed rationale for removed at-rules - Explain impact on cssMap validation
Zerowxm
dismissed stale reviews from kylorhall-atlassian and liamqma
via
7a89b56
3 participants
What is this change?
This PR bumps the
csstypedependency from version 3.1.3 to 3.2.3 across the monorepo.Why are we making this change?
csstype 3.2.3 reflects the evolution of CSS standards by:
Removing deprecated/obsolete at-rules:
@scroll-timeline- This CSS proposal was abandoned; Scroll-driven Animations now use theanimation-timelineproperty instead
@viewport- Obsolete at-rule with no modern browser support; viewport configuration is now handled via meta tagsand media queries
Adding modern CSS at-rules:
@container- CSS Container Queries (modern feature with growing browser support)@position-try- CSS Anchor Positioning (newer standard)@view-transition- View Transitions API (newer standard)This keeps Compiled's type definitions aligned with current CSS standards and enables support for modern CSS features.
How are we making this change?
package.json,packages/jest/package.json, andpackages/react/package.jsonAtRulestype mapping inpackages/babel-plugin/src/utils/css-map.tsto match csstype 3.2.3definitions
@scroll-timeline,@viewport) are not used anywhere in thecodebase
PR checklist
Don't delete me!
I have...
website/(not applicable - internal dependency bump)