-
Notifications
You must be signed in to change notification settings - Fork 71
chore: bump csstype from 3.1.3 to 3.2.3 #1867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| --- | ||
| "@compiled/babel-plugin": minor | ||
| "@compiled/react": minor | ||
| "@compiled/jest": minor | ||
| --- | ||
|
|
||
| Bump csstype from 3.1.3 to 3.2.3 and add missing `@container` support to cssMap validation | ||
|
|
||
| Updates csstype to the latest version which reflects the evolution of CSS standards. This change also fixes a bug where `@container` (CSS Container Queries) was partially supported in CSS processing but was missing from the cssMap type validation lookup table. | ||
|
|
||
| **Removed at-rules:** | ||
| - `@scroll-timeline` - Abandoned CSS proposal; Scroll-driven Animations now use `animation-timeline` property instead | ||
| - `@viewport` - Obsolete at-rule with no modern browser support; viewport configuration is now handled via meta tags and media queries | ||
|
|
||
| **Added at-rules (with full support):** | ||
| - `@container` - CSS Container Queries (now fully validated in cssMap) | ||
| - `@position-try` - CSS Anchor Positioning | ||
| - `@view-transition` - View Transitions API | ||
|
|
||
| **What changed:** | ||
| - Updated csstype dependency to 3.2.3 across all packages | ||
| - Updated `AtRules` type mapping in `packages/babel-plugin/src/utils/css-map.ts` to include the new at-rules and remove deprecated ones | ||
| - Bumped to `minor` for `@compiled/babel-plugin` due to adding `@container` support to cssMap validation | ||
|
|
||
| **Note:** The `@scroll-timeline` and `@viewport` at-rules are not used anywhere in the Compiled codebase, so this is not a breaking change. | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,6 +8,7 @@ export const EXTENDED_SELECTORS_KEY = 'selectors'; | |
|
|
||
| const atRules: Record<AtRules, boolean> = { | ||
| '@charset': true, | ||
| '@container': true, | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm pretty certain we had |
||
| '@counter-style': true, | ||
| '@document': true, | ||
| '@font-face': true, | ||
|
|
@@ -19,12 +20,12 @@ const atRules: Record<AtRules, boolean> = { | |
| '@media': true, | ||
| '@namespace': true, | ||
| '@page': true, | ||
| '@position-try': true, | ||
| '@property': true, | ||
| '@scope': true, | ||
| '@scroll-timeline': true, | ||
| '@starting-style': true, | ||
| '@supports': true, | ||
| '@viewport': true, | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This and
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Your changeset had a good description, I think it's fair. |
||
| '@view-transition': true, | ||
| }; | ||
|
|
||
| type ObjectKeyWithLiteralValue = t.Identifier | t.StringLiteral; | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -24,6 +24,6 @@ | |
| }, | ||
| "devDependencies": { | ||
| "@types/css": "^0.0.35", | ||
| "csstype": "^3.1.3" | ||
| "csstype": "^3.2.3" | ||
| } | ||
| } | ||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might need to be contributed to https://github.com/atlassian-labs/atlaspack/blob/main/crates/atlassian-swc-compiled-css/src/postcss/plugins/sort-atomic-style-sheet.rs (or thereabouts) as well.
cc: @JakeLane when he gets back