Skip to content

Recover safely after source restarts and time resets #68

Open

Description

@oguzkaganozt

Parent: #60

Problem

Two identity-lifecycle gaps remain after #66:

  • A new VP session with a later source stamp is accepted without a restart-specific latch. Existing restart runs needed re-enable because the outage exceeded the watchdog, not because session changes enforce it.
  • After source time moves backwards (rosbag replay or a CARLA episode reset), identity baselines keep the previous high stamp. Later input is rejected, the source goes stale and re-enable cannot recover; SI must currently be restarted.

Retired VP sessions are already rejected in both modes. The remaining task is to define recovery without weakening replay protection.

Done when

  • Define and enforce whether a VP session change requires SI_STOP and explicit re-enable, consistently in VP_CONTROL and SI_CONTROL + VP.
  • Define an explicit, authorized timeline-reset rule for Autoware and VP. Legitimate resets can recover, but re-enable must not silently make old sessions/cycles or old-episode ego data acceptable again. No mode/source fallback.
  • Controller-level tests cover a fast VP restart, alternating producers, repeated frames, cycle/stamp regressions, rosbag replay and CARLA episode reset. Verify duplicates do not refresh watchdogs, retired/replayed input stays rejected, and authorized recovery resumes only as specified.
  • Verify SI's own output-session identity across restarts on supported targets, including targets without RTC/SNTP; fix collisions if found. The clock-derived session concern from SI: hardening and test backlog from the #66 review #69 is not yet target-verified. Check session/sequence correlation across reboot.
  • Document the rules in the Finalize the VP–SI control contract #62 contract and link repeatable recovery/replay evidence.

References

The original timeline-reset finding came from code review, not a reproduced rig run; add reproduction evidence rather than treating it as already measured.

Activity

  1. changed the title [-]SI: re-enable cannot recover after the source timeline resets (stamp regression)[/-] [+]Recover safely after source restarts and time resets[/+] on Oct 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions