Skip to content

refactor(ansible): drop setup-dev-env.sh and legacy playbooks - #7169

Merged
xmfcx merged 2 commits into
mainfrom
refactor/ansible-phase2-remove-deprecated-entrypoints
Jul 21, 2026
Merged

xmfcx merged 2 commits into
mainfrom
refactor/ansible-phase2-remove-deprecated-entrypoints

Conversation

@xmfcx

@xmfcx xmfcx commented Jun 20, 2026 •

Copy link
Copy Markdown
Contributor

Why

These entrypoints were superseded in Phase 1 by ansible/scripts/install-ansible.sh + direct ansible-playbook invocations and the install_* playbooks. Deleting them removes a 200-line bash wrapper and a set of inconsistently named / duplicated playbooks, leaving one predictable way to set up a dev environment.

Removed → replacement

Removed Replacement
setup-dev-env.sh install-ansible.sh + ansible-playbook autoware.dev_env.install_dev_env
ansible/playbooks/docker.yaml install_docker.yaml
ansible/playbooks/universe.yaml install_dev_env.yaml
ansible/playbooks/openadkit.yaml install_dev_env.yaml
ansible/playbooks/role_rmw_implementation.yaml install_rmw.yaml (was a duplicate)
ansible/playbooks/setup_acados.yaml --tags acados
ansible/playbooks/download_artifacts.yaml --tags artifacts
ansible/playbooks/install_rviz_theme.yaml --tags qt5ct_setup
ansible/playbooks/install_spconv.yaml --tags spconv
ansible/playbooks/telegraf.yaml + ansible/roles/telegraf/ none (unused; role removed entirely)

Test plan

  • No internal references to any removed file remain (expect no output):
    grep -rIn --exclude-dir=.git -E 'setup-dev-env\.sh|playbooks/(docker|universe|openadkit|role_rmw_implementation|setup_acados|download_artifacts|install_rviz_theme|install_spconv|telegraf)\.yaml|roles/telegraf|dev_env\.(universe|openadkit|telegraf|docker)\b' ansible docker .github .webauto-ci
  • Replacement entrypoints are present:
    ls ansible/scripts/install-ansible.sh ansible/playbooks/install_dev_env.yaml ansible/playbooks/install_docker.yaml ansible/playbooks/install_rmw.yaml ansible/playbooks/install_image_deps.yaml ansible/playbooks/install_nvidia.yaml
  • Fresh dev-env install via the new path succeeds (isolated, not on host; nvidia skipped for a GPU-less runner, artifacts skipped to avoid multi-GB ONNX downloads):
    docker run --rm ubuntu:24.04 bash -c "export DEBIAN_FRONTEND=noninteractive && apt-get update && apt-get install -y git sudo && git clone --branch refactor/ansible-phase2-remove-deprecated-entrypoints https://github.com/autowarefoundation/autoware /autoware && cd /autoware && bash ansible/scripts/install-ansible.sh && export PATH=\"\$HOME/.local/bin:\$PATH\" && ansible-galaxy collection install -f -r ansible-galaxy-requirements.yaml && ansible-playbook autoware.dev_env.install_dev_env --skip-tags nvidia,artifacts"
  • CI green: setup-universe and docker-build-and-push workflows pass (they exercise install_image_deps / install_nvidia / install_rmw, never the removed files).

@xmfcx
xmfcx requested a review from oguzkaganozt as a code owner June 20, 2026 13:38
@xmfcx xmfcx added the type:installation Issues or improvements related to the installation process of the software. label Jun 20, 2026
@xmfcx
xmfcx requested a review from youtalk as a code owner June 20, 2026 13:38
@xmfcx xmfcx added type:build Tooling and infrastructure around building the Autoware. type:containers Docker containers, containerization of components, or container orchestration. labels Jun 20, 2026
@xmfcx xmfcx added type:installation Issues or improvements related to the installation process of the software. type:build Tooling and infrastructure around building the Autoware. type:containers Docker containers, containerization of components, or container orchestration. labels Jun 20, 2026
@xmfcx xmfcx self-assigned this Jun 20, 2026
@github-actions

github-actions Bot commented Jun 20, 2026 •

Copy link
Copy Markdown
Contributor

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@xmfcx xmfcx added the run:health-check Run health-check label Jun 20, 2026
xmfcx added a commit that referenced this pull request Jun 20, 2026
The changed-files gate in several workflows reads the `any_changed`
output of step-security/changed-files, which only counts added, copied,
modified and renamed files and excludes deletions. As a result a PR or
push that only deletes files under a workflow's path filter silently
skips its real work, while the required gate treats the skip as a pass.

Switch the gates to `any_modified`, which additionally counts deleted
files, so added / modified / renamed / deleted changes all trigger the
workflow:

- health-check-ansible.yaml
- health-check-ansible-artifacts.yaml
- health-check-pr.yaml
- docker-build-and-push.yaml

Found while reviewing #7169, a deletion-only ansible PR that silently
skipped the install-dev-env health check.

Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org>
@mitsudome-r

Copy link
Copy Markdown
Member

I'm going to confirm if this is okay from TIER IV and other repositories.

Phase 2 of #7052. Deletes setup-dev-env.sh and the legacy/duplicate
playbooks that were marked for removal on 2026-05-24. They are superseded
by install-ansible.sh + direct ansible-playbook invocations and the
install_* playbooks landed in Phase 1.

Also removes the unused telegraf role, which had no callers other than
the deleted telegraf.yaml playbook.

Removed:
- setup-dev-env.sh -> install-ansible.sh + ansible-playbook
- ansible/playbooks/docker.yaml -> install_docker.yaml
- ansible/playbooks/universe.yaml -> install_dev_env.yaml
- ansible/playbooks/openadkit.yaml -> install_dev_env.yaml
- ansible/playbooks/role_rmw_implementation.yaml -> install_rmw.yaml (duplicate)
- ansible/playbooks/setup_acados.yaml -> --tags acados
- ansible/playbooks/download_artifacts.yaml -> --tags artifacts
- ansible/playbooks/install_rviz_theme.yaml -> --tags qt5ct_setup
- ansible/playbooks/install_spconv.yaml -> --tags spconv
- ansible/playbooks/telegraf.yaml -> no known callers
- ansible/roles/telegraf/ -> unused role, no callers

Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org>
@xmfcx
xmfcx force-pushed the refactor/ansible-phase2-remove-deprecated-entrypoints branch from 43da0b1 to 7e1beaa Compare June 20, 2026 23:18
@xmfcx

xmfcx commented Jun 20, 2026

Copy link
Copy Markdown
Contributor Author

@oguzkaganozt oguzkaganozt left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

openadkit.yaml is the only caller of the kisak_mesa role, so deleting it leaves kisak_mesa orphaned, the same condition used to justify removing telegraf. Either remove kisak_mesa too, or if the Mesa PPA is still needed, fold it into install_dev_env.yaml (it's not there today). Otherwise LGTM.

The kisak_mesa role was only referenced by the deleted openadkit.yaml
playbook, leaving it orphaned after Phase 2. The canonical
install_dev_env.yaml never included it, so this drops dead code rather
than changing any active install path, mirroring the telegraf removal.

Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org>

@youtalk youtalk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I use Telegraph personally, but I have no problem with it being deleted from the ansible.

@mergify

mergify Bot commented Jun 23, 2026

Copy link
Copy Markdown

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@xmfcx

xmfcx commented Jun 23, 2026 •

Copy link
Copy Markdown
Contributor Author

Thanks @oguzkaganozt removed kisak_mesa too.

It was only called from the now-deleted openadkit.yaml, and install_dev_env.yaml never included it, so there's no active install path that needs the Mesa PPA. It's also a non-mandatory, 22.04-only Rviz workaround.

Removing it keeps things consistent with the telegraf cleanup. Done in a3446a2

@xmfcx

xmfcx commented Jun 30, 2026 •

Copy link
Copy Markdown
Contributor Author

@mitsudome-r I'd like to merge this on Monday, 6th of July. It is already past more than 2 months from the initial scheduled date.

@mitsudome-r

Copy link
Copy Markdown
Member

There was some bug in the last week's test. We are redoing the test on Thursday with our bench to check if there are no regressions.

@xmfcx
xmfcx merged commit 691e13e into main Jul 21, 2026
25 checks passed
@xmfcx
xmfcx deleted the refactor/ansible-phase2-remove-deprecated-entrypoints branch July 21, 2026 15:20
TomcoGame pushed a commit to TomcoGame/Autoware-Assurance-Stack that referenced this pull request Oct 25, 2026
…#7170)

The changed-files gate in several workflows reads the `any_changed`
output of step-security/changed-files, which only counts added, copied,
modified and renamed files and excludes deletions. As a result a PR or
push that only deletes files under a workflow's path filter silently
skips its real work, while the required gate treats the skip as a pass.

Switch the gates to `any_modified`, which additionally counts deleted
files, so added / modified / renamed / deleted changes all trigger the
workflow:

- health-check-ansible.yaml
- health-check-ansible-artifacts.yaml
- health-check-pr.yaml
- docker-build-and-push.yaml

Found while reviewing autowarefoundation#7169, a deletion-only ansible PR that silently
skipped the install-dev-env health check.

Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org>
TomcoGame pushed a commit to TomcoGame/Autoware-Assurance-Stack that referenced this pull request Oct 25, 2026
…refoundation#7169)

* refactor(ansible): remove deprecated entrypoints and legacy playbooks

Phase 2 of autowarefoundation#7052. Deletes setup-dev-env.sh and the legacy/duplicate
playbooks that were marked for removal on 2026-05-24. They are superseded
by install-ansible.sh + direct ansible-playbook invocations and the
install_* playbooks landed in Phase 1.

Also removes the unused telegraf role, which had no callers other than
the deleted telegraf.yaml playbook.

Removed:
- setup-dev-env.sh -> install-ansible.sh + ansible-playbook
- ansible/playbooks/docker.yaml -> install_docker.yaml
- ansible/playbooks/universe.yaml -> install_dev_env.yaml
- ansible/playbooks/openadkit.yaml -> install_dev_env.yaml
- ansible/playbooks/role_rmw_implementation.yaml -> install_rmw.yaml (duplicate)
- ansible/playbooks/setup_acados.yaml -> --tags acados
- ansible/playbooks/download_artifacts.yaml -> --tags artifacts
- ansible/playbooks/install_rviz_theme.yaml -> --tags qt5ct_setup
- ansible/playbooks/install_spconv.yaml -> --tags spconv
- ansible/playbooks/telegraf.yaml -> no known callers
- ansible/roles/telegraf/ -> unused role, no callers

Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org>

* refactor(ansible): remove orphaned kisak_mesa role

The kisak_mesa role was only referenced by the deleted openadkit.yaml
playbook, leaving it orphaned after Phase 2. The canonical
install_dev_env.yaml never included it, so this drops dead code rather
than changing any active install path, mirroring the telegraf removal.

Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org>

---------

Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run:health-check Run health-check type:build Tooling and infrastructure around building the Autoware. type:containers Docker containers, containerization of components, or container orchestration. type:installation Issues or improvements related to the installation process of the software.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants