Repository navigation
refactor(ansible): drop setup-dev-env.sh and legacy playbooks - #7169
Conversation
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
The changed-files gate in several workflows reads the `any_changed` output of step-security/changed-files, which only counts added, copied, modified and renamed files and excludes deletions. As a result a PR or push that only deletes files under a workflow's path filter silently skips its real work, while the required gate treats the skip as a pass. Switch the gates to `any_modified`, which additionally counts deleted files, so added / modified / renamed / deleted changes all trigger the workflow: - health-check-ansible.yaml - health-check-ansible-artifacts.yaml - health-check-pr.yaml - docker-build-and-push.yaml Found while reviewing #7169, a deletion-only ansible PR that silently skipped the install-dev-env health check. Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org>
|
I'm going to confirm if this is okay from TIER IV and other repositories. |
Phase 2 of #7052. Deletes setup-dev-env.sh and the legacy/duplicate playbooks that were marked for removal on 2026-05-24. They are superseded by install-ansible.sh + direct ansible-playbook invocations and the install_* playbooks landed in Phase 1. Also removes the unused telegraf role, which had no callers other than the deleted telegraf.yaml playbook. Removed: - setup-dev-env.sh -> install-ansible.sh + ansible-playbook - ansible/playbooks/docker.yaml -> install_docker.yaml - ansible/playbooks/universe.yaml -> install_dev_env.yaml - ansible/playbooks/openadkit.yaml -> install_dev_env.yaml - ansible/playbooks/role_rmw_implementation.yaml -> install_rmw.yaml (duplicate) - ansible/playbooks/setup_acados.yaml -> --tags acados - ansible/playbooks/download_artifacts.yaml -> --tags artifacts - ansible/playbooks/install_rviz_theme.yaml -> --tags qt5ct_setup - ansible/playbooks/install_spconv.yaml -> --tags spconv - ansible/playbooks/telegraf.yaml -> no known callers - ansible/roles/telegraf/ -> unused role, no callers Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org>
43da0b1 to
7e1beaa
Compare
|
There was a problem hiding this comment.
openadkit.yaml is the only caller of the kisak_mesa role, so deleting it leaves kisak_mesa orphaned, the same condition used to justify removing telegraf. Either remove kisak_mesa too, or if the Mesa PPA is still needed, fold it into install_dev_env.yaml (it's not there today). Otherwise LGTM.
The kisak_mesa role was only referenced by the deleted openadkit.yaml playbook, leaving it orphaned after Phase 2. The canonical install_dev_env.yaml never included it, so this drops dead code rather than changing any active install path, mirroring the telegraf removal. Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org>
youtalk
left a comment
There was a problem hiding this comment.
I use Telegraph personally, but I have no problem with it being deleted from the ansible.
|
Tick the box to add this pull request to the merge queue (same as
|
|
Thanks @oguzkaganozt removed It was only called from the now-deleted Removing it keeps things consistent with the |
|
@mitsudome-r I'd like to merge this on Monday, 6th of July. It is already past more than 2 months from the initial scheduled date. |
|
There was some bug in the last week's test. We are redoing the test on Thursday with our bench to check if there are no regressions. |
…#7170) The changed-files gate in several workflows reads the `any_changed` output of step-security/changed-files, which only counts added, copied, modified and renamed files and excludes deletions. As a result a PR or push that only deletes files under a workflow's path filter silently skips its real work, while the required gate treats the skip as a pass. Switch the gates to `any_modified`, which additionally counts deleted files, so added / modified / renamed / deleted changes all trigger the workflow: - health-check-ansible.yaml - health-check-ansible-artifacts.yaml - health-check-pr.yaml - docker-build-and-push.yaml Found while reviewing autowarefoundation#7169, a deletion-only ansible PR that silently skipped the install-dev-env health check. Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org>
…refoundation#7169) * refactor(ansible): remove deprecated entrypoints and legacy playbooks Phase 2 of autowarefoundation#7052. Deletes setup-dev-env.sh and the legacy/duplicate playbooks that were marked for removal on 2026-05-24. They are superseded by install-ansible.sh + direct ansible-playbook invocations and the install_* playbooks landed in Phase 1. Also removes the unused telegraf role, which had no callers other than the deleted telegraf.yaml playbook. Removed: - setup-dev-env.sh -> install-ansible.sh + ansible-playbook - ansible/playbooks/docker.yaml -> install_docker.yaml - ansible/playbooks/universe.yaml -> install_dev_env.yaml - ansible/playbooks/openadkit.yaml -> install_dev_env.yaml - ansible/playbooks/role_rmw_implementation.yaml -> install_rmw.yaml (duplicate) - ansible/playbooks/setup_acados.yaml -> --tags acados - ansible/playbooks/download_artifacts.yaml -> --tags artifacts - ansible/playbooks/install_rviz_theme.yaml -> --tags qt5ct_setup - ansible/playbooks/install_spconv.yaml -> --tags spconv - ansible/playbooks/telegraf.yaml -> no known callers - ansible/roles/telegraf/ -> unused role, no callers Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org> * refactor(ansible): remove orphaned kisak_mesa role The kisak_mesa role was only referenced by the deleted openadkit.yaml playbook, leaving it orphaned after Phase 2. The canonical install_dev_env.yaml never included it, so this drops dead code rather than changing any active install path, mirroring the telegraf removal. Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org> --------- Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org>
setup-dev-env.shand the legacy/duplicate ansible playbooks that were marked for removal on 2026-05-24 during Phase 1.ansible/roles/telegrafrole, whose only caller was the deletedtelegraf.yamlplaybook.Why
These entrypoints were superseded in Phase 1 by
ansible/scripts/install-ansible.sh+ directansible-playbookinvocations and theinstall_*playbooks. Deleting them removes a 200-line bash wrapper and a set of inconsistently named / duplicated playbooks, leaving one predictable way to set up a dev environment.Removed → replacement
setup-dev-env.shinstall-ansible.sh+ansible-playbook autoware.dev_env.install_dev_envansible/playbooks/docker.yamlinstall_docker.yamlansible/playbooks/universe.yamlinstall_dev_env.yamlansible/playbooks/openadkit.yamlinstall_dev_env.yamlansible/playbooks/role_rmw_implementation.yamlinstall_rmw.yaml(was a duplicate)ansible/playbooks/setup_acados.yaml--tags acadosansible/playbooks/download_artifacts.yaml--tags artifactsansible/playbooks/install_rviz_theme.yaml--tags qt5ct_setupansible/playbooks/install_spconv.yaml--tags spconvansible/playbooks/telegraf.yaml+ansible/roles/telegraf/universe.yaml; the transition window has elapsed, please confirm those are migrated before merge.Test plan
grep -rIn --exclude-dir=.git -E 'setup-dev-env\.sh|playbooks/(docker|universe|openadkit|role_rmw_implementation|setup_acados|download_artifacts|install_rviz_theme|install_spconv|telegraf)\.yaml|roles/telegraf|dev_env\.(universe|openadkit|telegraf|docker)\b' ansible docker .github .webauto-cinvidiaskipped for a GPU-less runner,artifactsskipped to avoid multi-GB ONNX downloads):docker run --rm ubuntu:24.04 bash -c "export DEBIAN_FRONTEND=noninteractive && apt-get update && apt-get install -y git sudo && git clone --branch refactor/ansible-phase2-remove-deprecated-entrypoints https://github.com/autowarefoundation/autoware /autoware && cd /autoware && bash ansible/scripts/install-ansible.sh && export PATH=\"\$HOME/.local/bin:\$PATH\" && ansible-galaxy collection install -f -r ansible-galaxy-requirements.yaml && ansible-playbook autoware.dev_env.install_dev_env --skip-tags nvidia,artifacts"setup-universeanddocker-build-and-pushworkflows pass (they exerciseinstall_image_deps/install_nvidia/install_rmw, never the removed files).