Skip to content

fix(repositories): remove the rviz_2d_overlay_plugins 1.4.0 pin - #7354

Merged
xmfcx merged 1 commit into
autowarefoundation:mainfrom
xmfcx:remove-rviz-2d-overlay-plugins-pin
Oct 16, 2026
Merged

xmfcx merged 1 commit into
autowarefoundation:mainfrom
xmfcx:remove-rviz-2d-overlay-plugins-pin

Conversation

@xmfcx

@xmfcx xmfcx commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Description

This PR removes the temporary pin of core/external/rviz_2d_overlay_plugins at 1.4.0 from repositories/autoware.repos.

The pin was added because the jazzy deb of rviz_2d_overlay_plugins 1.4.1 had undefined vtables, so every RViz plugin that links it failed to load.

The fixed 1.4.2 is now in apt main for both distros:

Distro amd64 arm64
jazzy 1.4.2-1noble.20260915.193732 1.4.2-1noble.20260916.104105
humble 1.4.2-1jammy.20260915.231022 1.4.2-1jammy.20260916.135512

So autoware_rviz_plugins gets the library from the deb through rosdep again.

Dependency: the lockfiles

Locked builds (USE_LOCKFILE=true) take the ROS packages from the snapshot date in ansible/vars/locked-versions-*.yaml, not from apt main.

Distro Snapshot date rviz_2d_overlay_plugins in the snapshot
jazzy 2026-04-13 1.4.1 (broken)
humble 2026-05-14 1.4.0 (works)

Today the vendored copy hides the broken jazzy deb. So this PR must wait until the jazzy lockfiles move to a snapshot with 1.4.2 (2026-09-11 or later). The lockfile regeneration needs a CI fix first. This PR stays a draft until the lockfile PR merges.

Existing workspaces

vcs import does not delete. Delete src/core/external/rviz_2d_overlay_plugins by hand, or the vendored 1.4.0 keeps shadowing the deb. That is harmless.

rosdep install does not upgrade a package that is already installed. If a jazzy machine has the 1.4.1 deb, upgrade it with sudo apt install --only-upgrade ros-jazzy-rviz-2d-overlay-plugins.

After this merges

How was this PR tested?

See Verification below.

AI usage

AI usage: Written with Claude Code in Breeze, from the plan in the issue below.

Self-review: Two review rounds by a separate AI session with a clean context. Both rounds on 228e7bc found the same blocker: the jazzy lockfiles freeze at the 2026-04-13 snapshot, which serves the broken 1.4.1. This PR now waits for the lockfile bump. The second round also asked for the lockfile, deb version, and upgrade notes in this description, which are added.

Verification: The jazzy debs in apt `main` export all four vtables. The 5 dependent `autoware_rviz_plugins` packages build and link against the jazzy deb on amd64 without the vendored copy.

Symbols of the jazzy debs in apt main

  • nm -D librviz_2d_overlay_plugins.so from 1.4.2-1noble.20260915.193732 (amd64) and 1.4.2-1noble.20260916.104105 (arm64): all four _ZTVN23rviz_2d_overlay_plugins* vtables are D, including 18OverlayTextDisplayE and 15PieChartDisplayE, which were U in 1.4.1.
  • rosdep resolve rviz_2d_overlay_plugins gives ros-humble-rviz-2d-overlay-plugins and ros-jazzy-rviz-2d-overlay-plugins.
  • Did not run: the same nm check on the humble debs, because Decide how core rviz plugins should pin around broken upstream rviz_2d_overlay_plugins 1.4.1 autoware_core#1031 already checked humble 1.4.2.

Snapshot versions for the lockfiles

  • Read from snapshots.ros.org/<distro>/<date>/.../Packages.gz: jazzy 2026-04-13 serves 1.4.1-1noble.20260412.050605 (amd64) and 1.4.1-1noble.20260412.193720 (arm64). humble 2026-05-14 serves 1.4.0-1jammy.20260422.100043 (amd64) and 1.4.0-1jammy.20260426.014739 (arm64).

pre-commit run --files repositories/autoware.repos

  • All hooks passed or skipped.

Build of the dependent packages against the jazzy deb (amd64)

  • Host: Ubuntu 24.04, jazzy, ros-jazzy-rviz-2d-overlay-plugins 1.4.2-1noble.20260903.025214. This is the build of the 2026-09-11 snapshot, not the apt main build in the table. The nm check above ran on the apt main builds. I removed the vendored install/rviz_2d_overlay_* from every path variable.
  • colcon build --packages-select autoware_planning_rviz_plugin autoware_overlay_rviz_plugin autoware_topic_text_overlay_rviz_plugin autoware_string_stamped_rviz_plugin autoware_mission_details_overlay_rviz_plugin from autoware_rviz_plugins 0.6.0: Summary: 5 packages finished.
  • ldd resolves librviz_2d_overlay_plugins.so to /opt/ros/jazzy/lib/ for all 5 libraries.
  • dlopen with RTLD_NOW passed for 4 of them. libautoware_overlay_rviz_plugin.so fails RTLD_NOW on SignalDisplay::updateSmallOverlaySize. That method is declared and never defined. The build with the vendored 1.4.0 fails the same way, so it does not come from this PR. RTLD_LAZY passes for both builds.
  • Did not run: RViz or planning_simulator.launch.xml, so no plugin was loaded through pluginlib.
  • Did not run: humble and arm64 builds.
  • Did not run: the docker builds. run:health-check runs them in CI, without USE_LOCKFILE.

The jazzy deb of rviz_2d_overlay_plugins in apt main is now 1.4.2, and it
exports the vtables that 1.4.1 lacked. The humble deb was already fixed.
autoware_rviz_plugins gets the library from the deb through rosdep again.

See autowarefoundation/autoware_core#1031

Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org>
@xmfcx xmfcx added the run:health-check Run health-check label Oct 15, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@xmfcx xmfcx self-assigned this Oct 15, 2026
@xmfcx
xmfcx marked this pull request as ready for review October 15, 2026 14:01
@xmfcx
xmfcx requested a review from mitsudome-r as a code owner October 15, 2026 14:01
@xmfcx
xmfcx merged commit deef9da into autowarefoundation:main Oct 16, 2026
27 of 32 checks passed
@xmfcx
xmfcx deleted the remove-rviz-2d-overlay-plugins-pin branch October 16, 2026 14:38
xmfcx pushed a commit that referenced this pull request Oct 18, 2026
#7359)

Regenerated by the regenerate-lockfiles workflow. Reason: move jazzy past the 2026-04-13 snapshot, which serves the broken rviz_2d_overlay_plugins 1.4.1, so #7354 can remove the vendored pin.

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run:health-check Run health-check

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants