Repository navigation
fix(repositories): remove the rviz_2d_overlay_plugins 1.4.0 pin - #7354
Merged
xmfcx merged 1 commit intoOct 16, 2026
Merged
Conversation
The jazzy deb of rviz_2d_overlay_plugins in apt main is now 1.4.2, and it exports the vtables that 1.4.1 lacked. The humble deb was already fixed. autoware_rviz_plugins gets the library from the deb through rosdep again. See autowarefoundation/autoware_core#1031 Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org>
Contributor
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
mitsudome-r
approved these changes
Oct 16, 2026
xmfcx
pushed a commit
that referenced
this pull request
Oct 18, 2026
#7359) Regenerated by the regenerate-lockfiles workflow. Reason: move jazzy past the 2026-04-13 snapshot, which serves the broken rviz_2d_overlay_plugins 1.4.1, so #7354 can remove the vendored pin. Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the temporary pin of
core/external/rviz_2d_overlay_pluginsat1.4.0fromrepositories/autoware.repos.repositories/autoware.repos#L52-L56The pin was added because the jazzy deb of
rviz_2d_overlay_plugins1.4.1 had undefined vtables, so every RViz plugin that links it failed to load.The fixed 1.4.2 is now in apt
mainfor both distros:1.4.2-1noble.20260915.1937321.4.2-1noble.20260916.1041051.4.2-1jammy.20260915.2310221.4.2-1jammy.20260916.135512So
autoware_rviz_pluginsgets the library from the deb through rosdep again.Dependency: the lockfiles
Locked builds (
USE_LOCKFILE=true) take the ROS packages from the snapshot date inansible/vars/locked-versions-*.yaml, not from aptmain.rviz_2d_overlay_pluginsin the snapshot2026-04-131.4.1(broken)2026-05-141.4.0(works)Today the vendored copy hides the broken jazzy deb. So this PR must wait until the jazzy lockfiles move to a snapshot with 1.4.2 (2026-09-11 or later). The lockfile regeneration needs a CI fix first. This PR stays a draft until the lockfile PR merges.
Existing workspaces
vcs importdoes not delete. Deletesrc/core/external/rviz_2d_overlay_pluginsby hand, or the vendored 1.4.0 keeps shadowing the deb. That is harmless.rosdep installdoes not upgrade a package that is already installed. If a jazzy machine has the 1.4.1 deb, upgrade it withsudo apt install --only-upgrade ros-jazzy-rviz-2d-overlay-plugins.After this merges
How was this PR tested?
See Verification below.
AI usage
AI usage: Written with Claude Code in Breeze, from the plan in the issue below.
Self-review: Two review rounds by a separate AI session with a clean context. Both rounds on
228e7bcfound the same blocker: the jazzy lockfiles freeze at the 2026-04-13 snapshot, which serves the broken 1.4.1. This PR now waits for the lockfile bump. The second round also asked for the lockfile, deb version, and upgrade notes in this description, which are added.Verification: The jazzy debs in apt `main` export all four vtables. The 5 dependent `autoware_rviz_plugins` packages build and link against the jazzy deb on amd64 without the vendored copy.
Symbols of the jazzy debs in apt
mainnm -D librviz_2d_overlay_plugins.sofrom1.4.2-1noble.20260915.193732(amd64) and1.4.2-1noble.20260916.104105(arm64): all four_ZTVN23rviz_2d_overlay_plugins*vtables areD, including18OverlayTextDisplayEand15PieChartDisplayE, which wereUin 1.4.1.rosdep resolve rviz_2d_overlay_pluginsgivesros-humble-rviz-2d-overlay-pluginsandros-jazzy-rviz-2d-overlay-plugins.nmcheck on the humble debs, because Decide how core rviz plugins should pin around broken upstream rviz_2d_overlay_plugins 1.4.1 autoware_core#1031 already checked humble 1.4.2.Snapshot versions for the lockfiles
snapshots.ros.org/<distro>/<date>/.../Packages.gz: jazzy2026-04-13serves1.4.1-1noble.20260412.050605(amd64) and1.4.1-1noble.20260412.193720(arm64). humble2026-05-14serves1.4.0-1jammy.20260422.100043(amd64) and1.4.0-1jammy.20260426.014739(arm64).pre-commit run --files repositories/autoware.reposBuild of the dependent packages against the jazzy deb (amd64)
ros-jazzy-rviz-2d-overlay-plugins 1.4.2-1noble.20260903.025214. This is the build of the 2026-09-11 snapshot, not the aptmainbuild in the table. Thenmcheck above ran on the aptmainbuilds. I removed the vendoredinstall/rviz_2d_overlay_*from every path variable.colcon build --packages-select autoware_planning_rviz_plugin autoware_overlay_rviz_plugin autoware_topic_text_overlay_rviz_plugin autoware_string_stamped_rviz_plugin autoware_mission_details_overlay_rviz_pluginfromautoware_rviz_plugins0.6.0:Summary: 5 packages finished.lddresolveslibrviz_2d_overlay_plugins.soto/opt/ros/jazzy/lib/for all 5 libraries.dlopenwithRTLD_NOWpassed for 4 of them.libautoware_overlay_rviz_plugin.sofailsRTLD_NOWonSignalDisplay::updateSmallOverlaySize. That method is declared and never defined. The build with the vendored 1.4.0 fails the same way, so it does not come from this PR.RTLD_LAZYpasses for both builds.planning_simulator.launch.xml, so no plugin was loaded through pluginlib.run:health-checkruns them in CI, withoutUSE_LOCKFILE.