Fix unknown doc attribute Hidden at nightly#17
Fix unknown doc attribute Hidden at nightly#17bheisler merged 1 commit intobheisler:masterfrom zzau13:master
doc attribute Hidden at nightly#17Conversation
Brings down the crates to build, for `rslint-cli` to 119, which was 150 before this commit.
|
Also breaks my build. :( |
| }, | ||
|
|
||
| #[doc(Hidden)] | ||
| #[doc(hidden)] |
There was a problem hiding this comment.
But that's what I'm fixing. Is there a problem with the cache on the CI?
There was a problem hiding this comment.
Is there a problem with the cache on the CI?
criterion is being used as a dev-dependency, and it's importing this crate from crates.io.
There was a problem hiding this comment.
Ok, there is a cyclic dependency.
But this is a criterion bug nightly so it should be fixed from the criterion repository. From here I can't do anything. Remove dependency, little more.
It's just in the benchmarks I don't think it's important.
|
To be clear this is a rustc regression (rust-lang/rust#82662), and we hope to fix it in the next nightly (rust-lang/rust#82702), but until then it would be really great if this could be landed with a version bump |
|
Thanks for the pull request! |
The
Hiddendocattribute it's no longer valid at nightly