Cleaning up the network layer, refactored NetworkThread..#141
Merged
adamhass merged 6 commits intokompics:masterfrom Mar 8, 2021
Merged
Cleaning up the network layer, refactored NetworkThread..#141adamhass merged 6 commits intokompics:masterfrom
adamhass merged 6 commits intokompics:masterfrom
Conversation
… removal of unused code. Improved error handling and unwinding of NetworkThread panics.
Collaborator
Author
|
I'll force-push the cargo fmt after this PR has been merged: bheisler/TinyTemplate#17 |
Codecov Report
@@ Coverage Diff @@
## master #141 +/- ##
==========================================
+ Coverage 70.68% 71.89% +1.20%
==========================================
Files 90 92 +2
Lines 15844 16445 +601
==========================================
+ Hits 11200 11823 +623
+ Misses 4644 4622 -22
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR mainly restructures the NetworkThread to make it a bit more pleasant to work with/look at.
I'd prefer to merge it now so as to avoid potential merge conflicts later on when I actually add more stuff on top...
Improved error handling and added unwinding of the NetworkThread in net/mod.rs, I'm unsure if I'm doing it properly there but I think it should make for some nicer log messages if/when the NetworkThread panics.
Also made some more updates to the docs page for network buffers.
Please make sure these boxes are checked, before submitting a new PR.
rustfmton the code base before submitting (on latest nightly with rustfmt support)Issues
Reference or describe the issues this PR addresses.