Deprecate GTSAM_SLOW_BUT_CORRECT_EXPMAP#2043
Conversation
|
Some of the failing tests are because of quite different results (e.g. |
|
@dellaert the TSAM factor tests are failing with wildly different Jacobians (e.g. values of 7 in expected and 3 in actual). It might be something with how the factor Jacobians are being computed. Any thoughts since I am not super familiar with this at the moment? |
|
I'll take a look, please review Hat&Vee PR? |
|
I fixed all tests (on my MacBook) but had to comment out a test in GnC, @lucacarlone |
|
Okay nice, I had similar fixes locally but wanted to double check with you. |
dellaert
left a comment
dellaert
left a comment
There was a problem hiding this comment.
I think we need to add some computer time benchmarks before merging this
cmake/HandleGeneralOptions.cmake
Outdated
| option(GTSAM_SLOW_BUT_CORRECT_EXPMAP "Use slower but correct expmap for Pose2" OFF) | ||
| option(GTSAM_SLOW_BUT_CORRECT_EXPMAP "Use slower but correct expmap for Pose2" ON) | ||
|
|
||
| message(WARNING "GTSAM_SLOW_BUT_CORRECT_EXPMAP has been deprecated and will be removed in a future release.") |
There was a problem hiding this comment.
Should this message be displayed only when set to OFF?
2 participants
Set
GTSAM_SLOW_BUT_CORRECT_EXPMAPto ON by default and print deprecation warning.This is based on findings by @dellaert and I on the accuracy of the exponential map of
Pose2for hybrid state estimation with the City10000 dataset.With the flag off, we get
where the trajectory is elongated.
With the flag on, we get a better trajectory.
Similar results can be seen for longer trajectories (e.g. 220 timesteps).
Flag OFF
Flag ON