Skip to content

Remove mention of dead stores in comment for MemFlags::notrap#1828

Closed
leoyvens wants to merge 1 commit into
bytecodealliance:masterfrom
leoyvens:remove-dead-store-comment
Closed

Remove mention of dead stores in comment for MemFlags::notrap#1828
leoyvens wants to merge 1 commit into
bytecodealliance:masterfrom
leoyvens:remove-dead-store-comment

Conversation

@leoyvens
Copy link
Copy Markdown
Contributor

@leoyvens leoyvens commented Jun 5, 2020

Claiming that notrap makes it possible to remove a dead store seems incorrect. This contradicts inst_predicates.rs which considers anything that stores as having side effects.

@github-actions github-actions Bot added the cranelift Issues related to the Cranelift code generator label Jun 5, 2020
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 5, 2020

Subscribe to Label Action

cc @bnjbvr

Details This issue or pull request has been labeled: "cranelift"

Thus the following users have been cc'd because of the following labels:

  • bnjbvr: cranelift

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

@sunfishcode
Copy link
Copy Markdown
Member

The IR flag comment is talking about what's theoretically possible, and inst_predicates.rs is just what's currently implemented. notrap does still mean that it's possible to remove a store, if it can also be shown to be a dead store.

@leoyvens
Copy link
Copy Markdown
Contributor Author

leoyvens commented Jun 5, 2020

@sunfishcode Thanks for the response, that makes sense.

@leoyvens leoyvens closed this Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cranelift Issues related to the Cranelift code generator

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants