Skip to content

Remove mention of dead stores in comment for MemFlags::notrap #1828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
leoyvens wants to merge 1 commit into from
Closed

Remove mention of dead stores in comment for MemFlags::notrap #1828

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions cranelift/codegen/src/ir/memflags.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,7 @@ impl MemFlags {
/// also required to trap.
///
/// The `notrap` flag tells Cranelift that the memory is *accessible*, which means that
/// accesses will not trap. This makes it possible to delete an unused load or a dead store
/// instruction.
/// accesses will not trap. This makes it possible to delete an unused load instruction.
pub fn notrap(self) -> bool {
self.read(FlagBit::Notrap)
}
Expand Down