Add ELF TLS support in new x64 backend.#2540
Merged
Merged
Conversation
github-actions
Bot
added
cranelift
Contributor
|
cranelift/codegen/src/legalizer/tls.rs is empty |
bjorn3
reviewed
Jan 4, 2021
bjorn3
reviewed
Jan 4, 2021
bjorn3
reviewed
Jan 4, 2021
Contributor
bjorn3
left a comment
bjorn3
left a comment
There was a problem hiding this comment.
LGTM with the todo!() added.
cfallin
force-pushed
the
x64-tls
branch
2 times, most recently
from
d54298f to
dd23e50
Compare
bjorn3
approved these changes
Jan 4, 2021
cfallin
force-pushed
the
x64-tls
branch
5 times, most recently
from
9a865a6 to
cdeb4cf
Compare
bnjbvr
suggested changes
Jan 12, 2021
Member
bnjbvr
left a comment
bnjbvr
left a comment
There was a problem hiding this comment.
Looks good on principle, I wonder if there are ways to minimize code duplication, see below. Thanks!
Member
Author
|
Updated, thanks! |
This follows the implementation in the legacy x86 backend, including hardcoded sequence that is compatible with what the linker expects. We could potentially do better here, but it is likely not necessary. Thanks to @bjorn3 for a bugfix to an earlier version of this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #2538 and includes that commit in this PR.
This follows the implementation in the legacy x86 backend, including
hardcoded sequence that is compatible with what the linker expects. We
could potentially do better here, but it is likely not necessary.
Thanks to @bjorn3 for a bugfix to an earlier version of this.