Disable wasmtime default-features in wasi crate#2664
Merged
alexcrichton merged 1 commit intoFeb 18, 2021
Merged
Conversation
alexcrichton
approved these changes
Feb 18, 2021
Member
alexcrichton
left a comment
alexcrichton
left a comment
There was a problem hiding this comment.
Oops, thanks for catching this!
Subscribe to Label Actioncc @kubkon DetailsThis issue or pull request has been labeled: "wasi"Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
Contributor
|
Sorry, my bad, this got lost in a big PR. |
peterhuene
pushed a commit
to peterhuene/wasmtime
that referenced
this pull request
Feb 19, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disabling
wasmtime's default features in thewasicrate has been removed in the transition from0.22.0to0.23.0. This brings in a whole lot of unnecessary features and dependencies that thewasicrate doesn't need.Not sure if there was a specific reason for the removal or just a small accident. Anyways, here is a small change to disable
wasmtime's default features again. :)