Skip to content

Wasmtime 0.24.0#2707

Merged
sunfishcode merged 2 commits into
bytecodealliance:mainfrom
sunfishcode:sunfishcode/0.24.0
Mar 5, 2021
Merged

Wasmtime 0.24.0#2707
sunfishcode merged 2 commits into
bytecodealliance:mainfrom
sunfishcode:sunfishcode/0.24.0

Conversation

@sunfishcode
Copy link
Copy Markdown
Member

As reported in #2705, I made some semver-incompatible changes related to fs-set-times without properly bumping semver. This release is prompted by the need to update wasmtime past the problematic version. But this also happens to be a change to release the async functions support!

I used a specially modified version of the publish script to avoid
bumping the `witx` version.
@alexcrichton
Copy link
Copy Markdown
Member

I think it's fine to have a release of wamtime, but for this problem specifically it seems like the best solution would be to yank the versions of crates on crates.io that have the breaking change? That would keep wasmtime-working as-is (and anyone else depending on the crates)

@bnjbvr
Copy link
Copy Markdown
Member

bnjbvr commented Mar 4, 2021

I don't have an opinion on the right way to fix the semver issue above, but if this wasn't too much burden, it would be pretty nice to have a release that contained the fix provided in #2664 (this new released version would be the first one to include it).

@github-actions github-actions Bot added cranelift Issues related to the Cranelift code generator cranelift:area:peepmatic cranelift:meta Everything related to the meta-language. cranelift:module cranelift:wasm wasmtime:docs Issues related to Wasmtime's documentation labels Mar 4, 2021
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 4, 2021

Subscribe to Label Action

cc @fitzgen

Details This issue or pull request has been labeled: "cranelift", "cranelift:area:peepmatic", "cranelift:meta", "cranelift:module", "cranelift:wasm", "wasmtime:docs"

Thus the following users have been cc'd because of the following labels:

  • fitzgen: cranelift:area:peepmatic

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

@sunfishcode
Copy link
Copy Markdown
Member Author

Sounds like we should do both then. I'll figure out exactly what needs to be yanked, but since I already have this PR ready to go, we can also do a release. Anyone want to approve this PR? :-)

Copy link
Copy Markdown
Member

@cfallin cfallin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sunfishcode sunfishcode merged commit 8854dec into bytecodealliance:main Mar 5, 2021
@sunfishcode sunfishcode deleted the sunfishcode/0.24.0 branch March 5, 2021 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cranelift:meta Everything related to the meta-language. cranelift:module cranelift:wasm cranelift Issues related to the Cranelift code generator wasmtime:docs Issues related to Wasmtime's documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants