Vector bitcast support (AArch64 & Interpreter)#4820
Merged
Conversation
github-actions
Bot
added
cranelift
afonso360
reviewed
Aug 30, 2022
dheaton-arm
force-pushed
the
isle-bitcasts
branch
from
f510e61 to
b0bac79
Compare
dheaton-arm
force-pushed
the
isle-bitcasts
branch
from
b0bac79 to
e0d2b2c
Compare
akirilov-arm
requested review from
afonso360 and
cfallin
and removed request for
afonso360
cfallin
approved these changes
Sep 20, 2022
Member
cfallin
left a comment
cfallin
left a comment
There was a problem hiding this comment.
Thanks! One possible simplification (removing the mov instruction entirely) but otherwise LGTM.
dheaton-arm
force-pushed
the
isle-bitcasts
branch
from
e0d2b2c to
a54fd31
Compare
Implemented support for `bitcast` on vector values for AArch64 and the interpreter. Also corrected the verifier to ensure that the size, in bits, of the input and output types match for a `bitcast`, per the docs. Copyright (c) 2022 Arm Limited
Copyright (c) 2022 Arm Limited
Copyright (c) 2022 Arm Limited
dheaton-arm
force-pushed
the
isle-bitcasts
branch
from
a54fd31 to
a0d87fb
Compare
cfallin
approved these changes
Sep 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented support for
bitcaston vector values for AArch64 and theinterpreter.
Also corrected the verifier to ensure that the size, in bits, of the input and
output types match for a
bitcast, per the docs.Copyright (c) 2022 Arm Limited