Skip to content

cranelift: Added bitcast.f32 for i32, bitcast.f64 for i64 to interpreter.#4926

Closed
ArtBlnd wants to merge 3 commits into
bytecodealliance:mainfrom
ArtBlnd:interp-float-bitcast1
Closed

cranelift: Added bitcast.f32 for i32, bitcast.f64 for i64 to interpreter.#4926
ArtBlnd wants to merge 3 commits into
bytecodealliance:mainfrom
ArtBlnd:interp-float-bitcast1

Conversation

@ArtBlnd
Copy link
Copy Markdown
Contributor

@ArtBlnd ArtBlnd commented Sep 20, 2022

@afonso360
Related to #4920

@ArtBlnd ArtBlnd changed the title cranelift: Added bitcast.f32 for i32, bitcast.f64 for i64 to interpreter. cranelift: Added bitcast.f32 for i32, bitcast.f64 for i64 to interpreter. Sep 20, 2022
@github-actions github-actions Bot added the cranelift Issues related to the Cranelift code generator label Sep 20, 2022
Copy link
Copy Markdown
Contributor

@afonso360 afonso360 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@ArtBlnd
Copy link
Copy Markdown
Contributor Author

ArtBlnd commented Sep 20, 2022

Also looks test for bitcast.{i32, i64} for fp types are missing. I'll add it later when its merged.

@akirilov-arm
Copy link
Copy Markdown
Contributor

This looks like a duplicate of @dheaton-arm's PR #4820.

@ArtBlnd
Copy link
Copy Markdown
Contributor Author

ArtBlnd commented Sep 20, 2022

This looks like a duplicate of @dheaton-arm's PR #4820.

oh... yeah I didn't know about that. I'm closing pr.

@ArtBlnd ArtBlnd closed this Sep 20, 2022
@ArtBlnd
Copy link
Copy Markdown
Contributor Author

ArtBlnd commented Sep 20, 2022

but still I think that should be seperated.

@ArtBlnd ArtBlnd deleted the interp-float-bitcast1 branch September 20, 2022 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cranelift Issues related to the Cranelift code generator

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants