Skip to content

cranelift: Added bitcast.f32 for i32, bitcast.f64 for i64 to interpreter. #4926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ArtBlnd wants to merge 3 commits into from
Closed

cranelift: Added bitcast.f32 for i32, bitcast.f64 for i64 to interpreter. #4926

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a4fe51e
Added `bitcast.f32 for i32`, `bitcast.f64 for i64` to interpreter.
ArtBlnd Sep 20, 2022
bccb789
Added individual bitcast{.f32, .f64} tests.
ArtBlnd Sep 20, 2022
ef2c394
Fix-up typo.
ArtBlnd Sep 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 47 additions & 0 deletions cranelift/filetests/filetests/runtests/float-bitcast.clif
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
test interpret
test run
target x86_64
target aarch64
target s390x

function %bcast_i32_f32_i32_convert(i32) -> i32 {
block0(v0: i32):
v1 = bitcast.f32 v0
v2 = bitcast.i32 v1
return v2
}

; run: %bcast_i32_f32_i32_convert(0xFFFFFFFF) == 0xFFFFFFFF
; run: %bcast_i32_f32_i32_convert(0x12345678) == 0x12345678
; run: %bcast_i32_f32_i32_convert(0x0) == 0x0

function %bcast_i64_f64_i64_convert(i64) -> i64 {
block0(v0: i64):
v1 = bitcast.f64 v0
v2 = bitcast.i64 v1
return v2
}

; run: %bcast_i64_f64_i64_convert(0xFFFFFFFFFFFFFFFF) == 0xFFFFFFFFFFFFFFFF
; run: %bcast_i64_f64_i64_convert(0x1234567812345678) == 0x1234567812345678
; run: %bcast_i64_f64_i64_convert(0x0) == 0x0

function %bcast_i32_to_f32(i32) -> f32 {
block0(v0: i32):
v1 = bitcast.f32 v0
return v1
}

; run: %bcast_i32_to_f32(0xFFFFFFFF) == -NaN:0x3fffff
; run: %bcast_i32_to_f32(0x12345678) == 0x1.68acf0p-91
; run: %bcast_i32_to_f32(0x0) == 0x0.0

function %bcast_i64_to_f64(i64) -> f64 {
block0(v0: i64):
v1 = bitcast.f64 v0
return v1
}

; run: %bcast_i64_to_f64(0xFFFFFFFFFFFFFFFF) == -NaN:0x7ffffffffffff
; run: %bcast_i64_to_f64(0x1234567812345678) == 0x1.4567812345678p-732
; run: %bcast_i64_to_f64(0x0) == 0x0.0
2 changes: 2 additions & 0 deletions cranelift/interpreter/src/value.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,6 +309,8 @@ impl Value for DataValue {
}
(DataValue::F32(n), types::I32) => DataValue::I32(n.bits() as i32),
(DataValue::F64(n), types::I64) => DataValue::I64(n.bits() as i64),
(DataValue::I32(n), types::F32) => DataValue::F32(Ieee32::with_bits(n as u32)),
(DataValue::I64(n), types::F64) => DataValue::F64(Ieee64::with_bits(n as u64)),
(DataValue::B(b), t) if t.is_bool() => DataValue::B(b),
(DataValue::B(b), t) if t.is_int() => {
// Bools are represented in memory as all 1's
Expand Down