Skip to content

Update the spec test suite submodule#5970

Merged
alexcrichton merged 2 commits into
bytecodealliance:mainfrom
alexcrichton:update-testsuite
Mar 10, 2023
Merged

Update the spec test suite submodule#5970
alexcrichton merged 2 commits into
bytecodealliance:mainfrom
alexcrichton:update-testsuite

Conversation

@alexcrichton
Copy link
Copy Markdown
Member

Delete the local copies of the relaxed-simd test suite as well as they're now incorporated.

Closes #5914

Delete the local copies of the relaxed-simd test suite as well as
they're now incorporated.

Closes bytecodealliance#5914
@alexcrichton alexcrichton added this pull request to the merge queue Mar 9, 2023
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Mar 9, 2023
@alexcrichton alexcrichton added this pull request to the merge queue Mar 9, 2023
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Mar 9, 2023
Otherwise `(memory 0 0)` was being compiled as a static memory with huge
guards which we're trying to avoid in QEMU.
@alexcrichton
Copy link
Copy Markdown
Member Author

The test failures here I think are due to OOM for QEMU taking too much memory. After some investigation I found out that some of the new multi-memory tests add a few (memory 0 0) to modules to test when the memory index isn't 0 (and the "main memory" is somewhere in the middle of the index space. These 0-sized 0-max-size memories, however, were getting compiled as static memories (the "maximum size" is 0 after all) which meant they got static memory guards which was 4G of virtual memory which is a known way to get QEMU to OOM.

I've updated the test suite so that when under QEMU emulation we not only force dynamic memories but additionally all guards are removed. This further drastically reduces the virtual memory footprint, as intended, when under emulation and I think should make this landable.

FWIW running the spec tests in QEMU on my local machine took 1.3G max RSS prior and now it takes 250M so hopefully a nice improvement!

@alexcrichton alexcrichton enabled auto-merge March 10, 2023 16:33
alexcrichton added a commit to alexcrichton/wasmtime that referenced this pull request Mar 10, 2023
Maps to the corresponding `wasmtime::Config` option. The motivation here
is largely completeness and was something I was looking into with the
failures in bytecodealliance#5970
@alexcrichton alexcrichton added this pull request to the merge queue Mar 10, 2023
Merged via the queue into bytecodealliance:main with commit 7650d85 Mar 10, 2023
@alexcrichton alexcrichton deleted the update-testsuite branch March 10, 2023 17:30
alexcrichton added a commit that referenced this pull request Mar 10, 2023
Maps to the corresponding `wasmtime::Config` option. The motivation here
is largely completeness and was something I was looking into with the
failures in #5970
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove local copies of the relaxed-simd test suite

2 participants