riscv64: Add .vx format opcodes#6367
Merged
Merged
Conversation
github-actions
Bot
added
the
cranelift
afonso360
commented
May 10, 2023
| pub fn vec_reg_name(reg: Reg) -> String { | ||
| match reg.to_real_reg() { | ||
| Some(real) => { | ||
| assert_eq!(real.class(), RegClass::Float); |
Contributor
Author
There was a problem hiding this comment.
This assert triggers since we are now trying to format some integer registers and I didn't change the pretty printer. However this function gets removed in #6366, so I figured it's easier to wait for that to be merged and rebase this.
elliottt
reviewed
May 11, 2023
elliottt
left a comment
elliottt
left a comment
Member
There was a problem hiding this comment.
Just one quick question about the funct6 values for Vadd and Vsub, otherwise this looks great!
elliottt
approved these changes
May 11, 2023
elliottt
left a comment
elliottt
left a comment
Member
There was a problem hiding this comment.
Looks great, thank you Afonso!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👋 Hey,
This PR introduces
.vxformat opcodes, thesesplatan X or F register and perform the respective operation.I've only added
vadd,vsubandvrsub, but these are available for most opcodes.Additionally with the addition of
inegwe now pass thesimd_*_arith.wasttest suites 🎉 . I'm planning on enabling those when both this and the RegClass PR's are merged.