Cranelift: Break op cost ties with expression depth in egraphs#7456
Merged
Conversation
cfallin
reviewed
Nov 2, 2023
github-actions
Bot
added
the
cranelift
a1phyr
reviewed
Nov 3, 2023
elliottt
approved these changes
Nov 3, 2023
Mechanical change.
This means that, when the opcode cost is the same, we prefer shallow and wide expressions to narrow and deep. For example, `(a + b) + (c + d)` is preferred to `((a + b) + c) + d`. This is beneficial because it exposes more instruction-level parallelism and shortens live ranges. Co-Authored-By: Trevor Elliott <telliott@fastly.com>
Co-Authored-By: Chris Fallin <chris@cfallin.org> Co-Authored-By: Trevor Elliott <telliott@fastly.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This means that, when the opcode cost is the same, we prefer shallow and wide
expressions to narrow and deep. For example,
(a + b) + (c + d)is preferred to((a + b) + c) + d. This is beneficial because it exposes moreinstruction-level parallelism and shortens live ranges.
Follow up PRs will add rules that take advantage of this.
Depends on #7465