riscv64: Instruction selection improvements#7480
Merged
Merged
Conversation
alexcrichton
approved these changes
Nov 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👋 Hey,
This PR does two small instruction selection and encoding optimizations.
Use
addifor subsThis is one of the regressions that showed up in #7468. That PR changes
iadd_imm(x, -k)toisub(x, iconst(k)). We can use the sameiaddinstruction for both, but we didn't have a rule to do it.So we now try to negate an Imm12 and if we are able to do that we emit an
addiwhen subtracting.Try to swap registers when encoding compressed instructions for commutative operations
This is pretty much the same as #7471 but for all of the remaining compressed commutative instructions.
It allows us to emit these instructions as compressed more often.