riscv64: Rollback isub const LHS optimization#7491
Merged
Conversation
afonso360
added
the
cranelift:area:riscv64
github-actions
Bot
added
the
cranelift
alexcrichton
approved these changes
Nov 7, 2023
alexcrichton
pushed a commit
to alexcrichton/wasmtime
that referenced
this pull request
Nov 8, 2023
alexcrichton
added a commit
that referenced
this pull request
Nov 8, 2023
* wasi-http: Reject delete of forbidden headers (#7490) * Don't delete forbidden headers * Make delete return a result * Fix test that wasn't updated for fallible delete changes * riscv64: Rollback isub lhs optimization (#7491) --------- Co-authored-by: Trevor Elliott <telliott@fastly.com> Co-authored-by: Afonso Bordado <afonso360@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👋 Hey,
This PR fixes a bug with #7480. Where we used
addiinstead ofisubwhen either the LHS or RHS are constant. This is correct for the RHS rule, but not for LHS since the subtraction isn't commutative.