winch: Check for stack overflow

[elliottt]

Add stack overflow checking to the x64 backend in winch, and enable the runtime test for overflow. The method for checking for overflow is to compare sp against the stack limit from vmctx after the stack pointer has been adjusted to hold the locals for the function.

[github-actions]

Subscribe to Label Action

cc @saulecabrera

Details

This issue or pull request has been labeled: "winch"

Thus the following users have been cc'd because of the following labels:

• saulecabrera: winch

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

[saulecabrera]

LGTM, thanks! Just a comment regarding tests, and after that this should be ready to land.

Regarding filetests and disassembly, -- as mentioned offline -- I think it's a very reasonable thing to do. I just couldn't come up with a straightforward and sound way to do it, in the brief exploration that I did for this. I'd like to keep labels around for filetests that require jumps and such, if possible. Perhaps we can continue the discussion in #7552?

[saulecabrera]

I think this is due to incomplete unwind information encoding in Windows. All test that involve traps, currently fail on Windows for this reason. I think it's fine to ignore the tests introduced in this PR, temporarily in https://github.com/bytecodealliance/wasmtime/blob/main/build.rs#L210

[elliottt]

I think this is due to incomplete unwind information encoding in Windows. All test that involve traps, currently fail on Windows for this reason. I think it's fine to ignore the tests introduced in this PR, temporarily in https://github.com/bytecodealliance/wasmtime/blob/main/build.rs#L210

Thank you for tracking this down! I was really dreading having to debug a windows failure 😅

[elliottt]

Also in an argument for merging #7782 first, removing instruction offsets cuts the diff of this PR in half 👍