winch: Reduce instruction offset printing in winch#7782
Merged
elliottt merged 3 commits intoJan 17, 2024
Conversation
elliottt
requested review from
fitzgen and
saulecabrera
and removed request for
a team
Only emit instruction offsets at basic block boundaries, or for all instructions after a return. The reason behind the latter, is that many of the instructions after a return are traps, and will be common jump targets.
elliottt
force-pushed
the
trevor/winch-no-asm-offsets
branch
from
fae7bda to
e030db8
Compare
Subscribe to Label ActionDetailsThis issue or pull request has been labeled: "winch"Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
saulecabrera
approved these changes
Jan 17, 2024
Member
saulecabrera
left a comment
saulecabrera
left a comment
There was a problem hiding this comment.
Thanks for working on this. I agree that the diff is now less noisy and that in most cases it's easy to verify by looking what's going on in the disassembly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to make updates to winch filetess a bit less noisy, restrict isntruction offset printing to two cases:
retThe reason behind
2is that often instructions following aretwill be part of the trap table, and will thus be a common jump target from other areas of the function.This approach isn't perfect, as jumping over single instructions won't end up forcing the destination to have a label. However, it does get most cases right, and makes changes to the disassembly much smaller.
Fixes #7552