Add workflow for running integration tests on a dedicated VM#113
Merged
RomanIakovlev merged 4 commits intomainfrom Nov 19, 2024
Merged
Add workflow for running integration tests on a dedicated VM#113RomanIakovlev merged 4 commits intomainfrom
RomanIakovlev merged 4 commits intomainfrom
Conversation
RomanIakovlev
requested review from
Copilot,
elrayle and
qtomlinson
and removed request for
Copilot
qtomlinson
reviewed
Nov 6, 2024
Collaborator
qtomlinson
left a comment
qtomlinson
left a comment
There was a problem hiding this comment.
Great improvement for running the integration tests! Minor comments for the tests.
Collaborator
|
The custom infra does not have access to other services, e.g. Application Insight or Azure Search. Some of the integration tests may fail. If verifying definitions is the main purpose, in a future PR, we can change to run only definitionTest. |
qtomlinson
reviewed
Nov 6, 2024
| # Replace both GitHub tokens with the provided token | ||
| sed -i "s/^CRAWLER_GITHUB_TOKEN=.*/CRAWLER_GITHUB_TOKEN=${GITHUB_TOKEN}/" .env | ||
| sed -i "s/^CURATION_GITHUB_TOKEN=.*/CURATION_GITHUB_TOKEN=${GITHUB_TOKEN}/" .env | ||
| echo "" >> .env && echo "CRAWLER_SCANCODE_PARALLELISM=14" >> .env |
Collaborator
There was a problem hiding this comment.
As a separate PR, could we document CRAWLER_SCANCODE_PARALLELISM in the environment variable section in https://github.com/clearlydefined/operations/blob/main/overview.md?
RomanIakovlev
force-pushed
the
roman/it_infra1
branch
from
f1867a9 to
d441c08
Compare
Collaborator
Author
|
@qtomlinson thanks for your feedback, I've added the changes you requested. I have to admit, it looks much better this way! |
This was referenced Nov 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds a new workflow to run the existing integration tests on a dedicated virtual machine, created and destroyed for each test run.
This workflow creates and provisions a VM, using the Docker Compose setup available at https://github.com/clearlydefined/docker_dev_env_experiment. After provisioning, it runs the existing integration test suite against that newly created environment.
Advantage of running tests on custom infra is that it's possible to use a more powerful machine for the crawler, leading to a much faster test execution. E.g. static components test completes in ~5 minutes on a 16-core VM.