Run the entire end to end test suite in integration test#114
Merged
qtomlinson merged 3 commits intoclearlydefined:mainfrom Nov 26, 2024
Merged
Run the entire end to end test suite in integration test#114qtomlinson merged 3 commits intoclearlydefined:mainfrom
qtomlinson merged 3 commits intoclearlydefined:mainfrom
Conversation
Run definition tests in integration testing on the custom infra structure.
The timeout value is also used to control the interval between tests. This adjustment allows for longer rests between tests.
qtomlinson
force-pushed
the
qt/fix_service_test
branch
from
7fe36c2 to
7a40c47
Compare
ljones140
reviewed
Nov 25, 2024
Contributor
ljones140
left a comment
ljones140
left a comment
There was a problem hiding this comment.
Look great, I just have a quick question about the npm run changes
| id: verify-service-functions | ||
| continue-on-error: true | ||
| run: DEV_API_BASE_URL=${{ env.DEV_API_BASE_URL }} DYNAMIC_COORDINATES=${{ matrix.dynamicCoordinates }} npm run e2e-test-service | ||
| run: DEV_API_BASE_URL=${{ env.DEV_API_BASE_URL }} DYNAMIC_COORDINATES=${{ matrix.dynamicCoordinates }} npm run e2e-test-definition |
Contributor
There was a problem hiding this comment.
Just curious why has this changed from e2e-test-service to e2e-test-definition
Collaborator
Author
There was a problem hiding this comment.
This relates to a previous conversation.
ljones140
approved these changes
Nov 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run definition tests in integration testing on the custom infra structure.
Also add the option of skipping harvest for static components as the harvest can take quite some time.