Attempt to removed xtl dependency#110
Closed
anutosh491 wants to merge 1 commit intocompiler-research:mainfrom
Closed
Attempt to removed xtl dependency#110anutosh491 wants to merge 1 commit intocompiler-research:mainfrom
anutosh491 wants to merge 1 commit intocompiler-research:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #110 +/- ##
==========================================
+ Coverage 62.66% 63.45% +0.79%
==========================================
Files 15 15
Lines 600 613 +13
Branches 59 60 +1
==========================================
+ Hits 376 389 +13
Misses 224 224
|
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Collaborator
Author
|
Hmm wait, I think pertaining to this line |
Contributor
|
Ah, that's a good point... :( |
Collaborator
|
I think most of the features we use from the xtl are actually specific to xeus, meaning we could actually move or duplicate the code in xeus. I'm not 100% sure though. |
Merged
anutosh491
added a commit
to anutosh491/xeus-cpp
that referenced
this pull request
Jun 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #108