Conversation
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
vgvassilev
requested review from
JohanMabille and
alexander-penev
and removed request for
JohanMabille
|
@anutosh491 maybe link this to the issues about removing the xtl dependency and update the readme about depenencies on the main |
|
@anutosh491 The failing test is the one which loads the image as it makes use of xtl when it loads the xtl header |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
alexander-penev
left a comment
alexander-penev
left a comment
There was a problem hiding this comment.
Yes, everything looks very good, only the test crashes because of the removed xtl. If the test works out to not use the now removed xtl, the PR can be merged.
Ahh I overlooked this. Thanks for the debug :) |
|
@anutosh491 will this also fix #54 since its related to xtl? |
|
Hmm, let me think through it. I think it might just solve that ! |
Well the 2 problems have some overlap but are a bit different. I think I have a way to tackle the issue, will solve it through a subsequent PR. |
|
@anutosh491 xeus_REQUIRED_VERSION needs to be version 5.1.0 now |
Yeah I think I would use |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
anutosh491
force-pushed
the
xeus_5
branch
2 times, most recently
from
0064438 to
fcedf53
Compare
|
cc @alexander-penev @vgvassilev @mcbarton |
|
Ahh okay 1 thing. I'll address the readme too :) |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #127 +/- ##
==========================================
+ Coverage 79.31% 79.41% +0.10%
==========================================
Files 17 17
Lines 609 612 +3
Branches 59 59
==========================================
+ Hits 483 486 +3
Misses 126 126
|
|
clang-tidy review says "All clean, LGTM! 👍" |
anutosh491
force-pushed
the
xeus_5
branch
2 times, most recently
from
94d9344 to
2bab746
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
|
cc @vgvassilev ready ! |
6 participants
Fixes #108
Closes #110