Added pull_request_template.md#118
Merged
JohanMabille merged 2 commits intocompiler-research:mainfrom Jun 4, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #118 +/- ##
==========================================
+ Coverage 70.09% 75.08% +4.98%
==========================================
Files 17 17
Lines 602 602
Branches 59 59
==========================================
+ Hits 422 452 +30
+ Misses 180 150 -30 |
Collaborator
|
Well tough to comment on what sort of PR template we need (and if we need one) cause I've not seen any other xues stack have one :| |
Collaborator
Author
|
@JohanMabille can you review this PR for me? |
Collaborator
Author
|
@vgvassilev can you see if you can get this PR looked at? |
Merged
Collaborator
Author
|
@JohanMabille I have removed the checklist section and tests section. This should address all your comments. Are you happy with it now? |
Collaborator
|
Yep, thanks ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a basic pull request template to the repo. @vgvassilev @anutosh491 This PR is ready for review.